A heads up about a new extension (Gather [1]) being deployed to the cluster on Thursday [2]. We are aiming to deploy to testwiki on Thursday 26th March and English Wikipedia on Monday 30th March.
We're not expecting this to cause any problems since traffic is limited to the mobile beta mode of the site which accounts for 1/70th of mobile traffic and approximately only 500 of those users are logged in (and this feature is primarily for logged in users).
The extension makes use of the API, firing an API query request when 1) the special page is loaded (available to all users including anons). The special page is only linked to within the beta site (in the main menu) for logged in users so all traffic. However traffic is expected from social networks and links from wiki pages. 2) when the watchstar is clicked by a logged BETA user
I'm not expecting any problems with this deployment, but in worse case scenario since this is an experimental feature and we can disable the extension in the unlikely event that we hit any issues.
Please let me know if you have any further questions and please complain to me if notice any issues. We've announced this on en:vp [3]. For anything non-ops related feel free to engage in the conversation there.
Thanks! Jon R, mobile web team
[1] https://www.mediawiki.org/wiki/Extension:Gather [2] https://phabricator.wikimedia.org/T91341 [3] https://en.m.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29#Exten...
On Tue, Mar 24, 2015 at 7:01 PM, Jon Robson jrobson@wikimedia.org wrote:
Please let me know if you have any further questions and please complain to me if notice any issues.
Just from giving the API portion a once-over:
API documentation is severely lacking, see http://en.wikipedia.beta.wmflabs.org/w/api.php?action=help&modules=editl...
Lots of internal FauxRequests calls to ApiMain, that's bad code structure.
Database error when using lspnamespace.
Ordering/continuation in ApiQueryListPages::queryListItems isn't necessarily total, if the DB somehow gets duplicate gli_order.
ApiQueryListPages should be putting its result array under the 'query' node, not as its own top-level node. You probably copied list=watchlistraw, for which see T36356.
Continuation is broken here: http://en.wikipedia.beta.wmflabs.org/w/api.php?action=query&list=lists&a... (your continuation value should include all fields in your ORDER BY)
There's a similar possibility for broken continuation when 'mode' is set, or else your query is probably making MySQL be stupid by ordering by constant gl_perm.
You're returning booleans as booleans without code for adding the metadata being added in Gerrit change 182858, which means you're going to have issues once that change is merged. You'll probably also have some deprecation warnings once that is merged.
Bad tag names in http://en.wikipedia.beta.wmflabs.org/w/api.php?action=query&list=lists&a..., because you're directly screwing up the metadata element.
Anomie, thanks for the review! Inline...
API documentation is severely lacking, see
http://en.wikipedia.beta.wmflabs.org/w/api.php?action=help&modules=editl... http://en.wikipedia.beta.wmflabs.org/w/api.php?action=help&modules=editlist%7Cquery+listpages%7Cquery+lists
Agree, should be fixed now that API is more stable.
Lots of internal FauxRequests calls to ApiMain, that's bad code structure.
Are you suggesting we should not use API internally? I do think we should have a better set of functions for calling API internally as part of the core functionality. I wanted to start the discussion on that, but separately from this thread.
Database error when using lspnamespace.
Good catch, thanks, fixed in https://gerrit.wikimedia.org/r/#/c/199615/
Ordering/continuation in ApiQueryListPages::queryListItems isn't necessarily total, if the DB somehow gets duplicate gli_order.
Yep, patch was already pending for that - https://gerrit.wikimedia.org/r/#/c/199510/
ApiQueryListPages should be putting its result array under the 'query' node, not as its own top-level node. You probably copied list=watchlistraw, for which see T36356.
Thanks, will fix
Continuation is broken here: http://en.wikipedia.beta.wmflabs.org/w/api.php?action=query&list=lists&a... (your continuation value should include all fields in your ORDER BY)
There's a similar possibility for broken continuation when 'mode' is set, or else your query is probably making MySQL be stupid by ordering by constant gl_perm.
gl_perm is a constant for that query, i was unsure if Mysql would pick the right index here, so included it in the "order by" just to be safe. I could force index instead - what's the best practice with the new mysql?
You're returning booleans as booleans without code for adding the metadata being added in Gerrit change 182858, which means you're going to have issues once that change is merged. You'll probably also have some deprecation warnings once that is merged.
Will look at it, thx for the heads up.
Bad tag names in http://en.wikipedia.beta.wmflabs.org/w/api.php?action=query&list=lists&a..., because you're directly screwing up the metadata element.
Thanks, will fix.
On Wed, Mar 25, 2015 at 11:12 AM, Yuri Astrakhan yastrakhan@wikimedia.org wrote:
Lots of internal FauxRequests calls to ApiMain, that's bad code structure.
Are you suggesting we should not use API internally?
Yes, that's exactly what I'm suggesting. Rather than marshalling through a FauxRequest and going through all the other overhead of the API, you should have some sort of backend class that does the necessary work and call that both from the API and from the places you're trying to call the API internally.
There's a similar possibility for broken continuation when 'mode' is set,
or else your query is probably making MySQL be stupid by ordering by constant gl_perm.
gl_perm is a constant for that query, i was unsure if Mysql would pick the right index here, so included it in the "order by" just to be safe. I could force index instead - what's the best practice with the new mysql?
I thought it might be, but I wasn't entirely sure.
MySQL tends to be even stupider than that: if you have "foo = 'constant'" in your WHERE clause and also ORDER BY foo, it will insist on filesorting. Unless they fixed that in the very latest versions of MariaDB.
Is there a plan to launch it in other languages?
I committed a patch that defines it as an extension used by Wikimedia in translatewiki,[1] but I'll be even happier to know for sure that there is a plan to launch it not only for English.
[1] https://gerrit.wikimedia.org/r/#/c/199917/
-- Amir Elisha Aharoni · אָמִיר אֱלִישָׁע אַהֲרוֹנִי http://aharoni.wordpress.com “We're living in pieces, I want to live in peace.” – T. Moore
2015-03-25 1:01 GMT+02:00 Jon Robson jrobson@wikimedia.org:
A heads up about a new extension (Gather [1]) being deployed to the cluster on Thursday [2]. We are aiming to deploy to testwiki on Thursday 26th March and English Wikipedia on Monday 30th March.
We're not expecting this to cause any problems since traffic is limited to the mobile beta mode of the site which accounts for 1/70th of mobile traffic and approximately only 500 of those users are logged in (and this feature is primarily for logged in users).
The extension makes use of the API, firing an API query request when
- the special page is loaded (available to all users including anons).
The special page is only linked to within the beta site (in the main menu) for logged in users so all traffic. However traffic is expected from social networks and links from wiki pages. 2) when the watchstar is clicked by a logged BETA user
I'm not expecting any problems with this deployment, but in worse case scenario since this is an experimental feature and we can disable the extension in the unlikely event that we hit any issues.
Please let me know if you have any further questions and please complain to me if notice any issues. We've announced this on en:vp [3]. For anything non-ops related feel free to engage in the conversation there.
Thanks! Jon R, mobile web team
[1] https://www.mediawiki.org/wiki/Extension:Gather [2] https://phabricator.wikimedia.org/T91341 [3] https://en.m.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29#Exten...
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
I'd love to... that's a question for Jon Katz/Moushira .. :-) There's no reason not to technically.
As far as I know, I think currently we are doing it to English only to minimise amount of communication needed (because of the moderation concerns we need to communicate to Village pumps etc..).
Jon
On Thu, Mar 26, 2015 at 8:30 AM, Amir E. Aharoni < amir.aharoni@mail.huji.ac.il> wrote:
Is there a plan to launch it in other languages?
I committed a patch that defines it as an extension used by Wikimedia in translatewiki,[1] but I'll be even happier to know for sure that there is a plan to launch it not only for English.
[1] https://gerrit.wikimedia.org/r/#/c/199917/
-- Amir Elisha Aharoni · אָמִיר אֱלִישָׁע אַהֲרוֹנִי http://aharoni.wordpress.com “We're living in pieces, I want to live in peace.” – T. Moore
2015-03-25 1:01 GMT+02:00 Jon Robson jrobson@wikimedia.org:
A heads up about a new extension (Gather [1]) being deployed to the cluster on Thursday [2]. We are aiming to deploy to testwiki on Thursday 26th March and English Wikipedia on Monday 30th March.
We're not expecting this to cause any problems since traffic is limited to the mobile beta mode of the site which accounts for 1/70th of mobile traffic and approximately only 500 of those users are logged in (and this feature is primarily for logged in users).
The extension makes use of the API, firing an API query request when
- the special page is loaded (available to all users including anons).
The special page is only linked to within the beta site (in the main menu) for logged in users so all traffic. However traffic is expected from social networks and links from wiki pages. 2) when the watchstar is clicked by a logged BETA user
I'm not expecting any problems with this deployment, but in worse case scenario since this is an experimental feature and we can disable the extension in the unlikely event that we hit any issues.
Please let me know if you have any further questions and please complain to me if notice any issues. We've announced this on en:vp [3]. For anything non-ops related feel free to engage in the conversation there.
Thanks! Jon R, mobile web team
[1] https://www.mediawiki.org/wiki/Extension:Gather [2] https://phabricator.wikimedia.org/T91341 [3] https://en.m.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29#Exten...
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Hi Amir, Yes! This is definitely something we want to do. We launched on En because we needed scale for testing and the feature has discoverability issues. If this rollout goes well, the only limit to rolling out in other languages (or even projects like wikivoyage and commons) is, as Jon R identified, is our bandwidth for communication.
Interested in spearheading that effort on one of your favorite languages, Amir?
Best,
J
On Thu, Mar 26, 2015 at 8:35 AM, Jon Robson jrobson@wikimedia.org wrote:
I'd love to... that's a question for Jon Katz/Moushira .. :-) There's no reason not to technically.
As far as I know, I think currently we are doing it to English only to minimise amount of communication needed (because of the moderation concerns we need to communicate to Village pumps etc..).
Jon
On Thu, Mar 26, 2015 at 8:30 AM, Amir E. Aharoni < amir.aharoni@mail.huji.ac.il> wrote:
Is there a plan to launch it in other languages?
I committed a patch that defines it as an extension used by Wikimedia in translatewiki,[1] but I'll be even happier to know for sure that there is a plan to launch it not only for English.
[1] https://gerrit.wikimedia.org/r/#/c/199917/
-- Amir Elisha Aharoni · אָמִיר אֱלִישָׁע אַהֲרוֹנִי http://aharoni.wordpress.com “We're living in pieces, I want to live in peace.” – T. Moore
2015-03-25 1:01 GMT+02:00 Jon Robson jrobson@wikimedia.org:
A heads up about a new extension (Gather [1]) being deployed to the cluster on Thursday [2]. We are aiming to deploy to testwiki on Thursday 26th March and English Wikipedia on Monday 30th March.
We're not expecting this to cause any problems since traffic is limited to the mobile beta mode of the site which accounts for 1/70th of mobile traffic and approximately only 500 of those users are logged in (and this feature is primarily for logged in users).
The extension makes use of the API, firing an API query request when
- the special page is loaded (available to all users including anons).
The special page is only linked to within the beta site (in the main menu) for logged in users so all traffic. However traffic is expected from social networks and links from wiki pages. 2) when the watchstar is clicked by a logged BETA user
I'm not expecting any problems with this deployment, but in worse case scenario since this is an experimental feature and we can disable the extension in the unlikely event that we hit any issues.
Please let me know if you have any further questions and please complain to me if notice any issues. We've announced this on en:vp [3]. For anything non-ops related feel free to engage in the conversation there.
Thanks! Jon R, mobile web team
[1] https://www.mediawiki.org/wiki/Extension:Gather [2] https://phabricator.wikimedia.org/T91341 [3] https://en.m.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29#Exten...
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l