There is a consistent failure on 2 tests in the Chrome build. Firefox build not effected.
These tests both depend on the window size being >= 768px
1) Table of contents.Show table of contents on tablet 2) Toggling sections.Section open by default on tablet
When run locally against beta labs they pass for me. Is there any known issues with cloudbees around browser window size manipulation? It's the only thing I can think that might be causing this issue.
The step that might not be working as expected is:
Given(/^I am viewing the site in tablet mode$/) do @browser.window.resize_to(768, 1024) end
https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs....
On Mon, Jun 2, 2014 at 1:43 PM, Jon Robson jdlrobson@gmail.com wrote:
There is a consistent failure on 2 tests in the Chrome build. Firefox build not effected.
Given(/^I am viewing the site in tablet mode$/) do @browser.window.resize_to(768, 1024) end
Watching these run, and checking official specs, I'd like to see what happens if you specify the window as (1024, 768) instead of (768, 1024). If I understand the test correctly it shouldn't make a difference as far as testing function, but Chrome seems to be calculating area based on a limited visible space available on the vertical axis. -Chris
Hi Chris I'm not sure what you are suggesting. As long as one of those numbers is >= 768px the tablet styles and scripts should kick in. Even if it was 768x768 or 768*300 it should work... Is there anyway to run the tests against cloudbees and manually check the window size that is being rendered? We could blindly up this to something like 1000x1000 but that feels hacky...
Jon
On Mon, Jun 2, 2014 at 4:51 PM, Chris McMahon cmcmahon@wikimedia.org wrote:
On Mon, Jun 2, 2014 at 1:43 PM, Jon Robson jdlrobson@gmail.com wrote:
There is a consistent failure on 2 tests in the Chrome build. Firefox build not effected.
Given(/^I am viewing the site in tablet mode$/) do @browser.window.resize_to(768, 1024) end
Watching these run, and checking official specs, I'd like to see what happens if you specify the window as (1024, 768) instead of (768, 1024). If I understand the test correctly it shouldn't make a difference as far as testing function, but Chrome seems to be calculating area based on a limited visible space available on the vertical axis. -Chris
QA mailing list QA@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/qa