Ed Sanders, Trevor and I had an in real life conversation, last Friday, where we spoke about the VisualEditor tablet (and future mobile) offering. We've had a bunch of issues with it so far breaking and a lot of this is due to two conflicting technologies.
We're keen to bring VE code and mobile code closer together with the ultimate goal to get a good VisualEditor mobile experience going.
Since Damon has asked us all to get VisualEditor released this quarter, between us we think mobile VE will become a high priority soon.
We'd thus like to spend this quarter making the VisualEditorOverlay [1] more OOJS UI like.
Ideally all the existing code should live in VisualEditor and be based on OOJS UI. In the future we could also imagine the wikitext editor in mobile becoming part of the VisualEditor tool itself.
At a bare minimum this could be rewritten as an OOJS UI dialog [2] and would require us looking at the mobile overlay manager and seeing if it can be consolidated with VisualEditor's seemingly similar window manager [3] which I do not believe has any support for storing state via the hash fragment [citation needed, please correct me]
As a result of this work, the mobile frontend code and VisualEditor's front end code should naturally become more aligned.
Ed, Trevor anything you would like to add to the above? Any corrections to my interpretation of this chat?
[1] https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master... [2] https://doc.wikimedia.org/oojs-ui/master/#!/api/OO.ui.Dialog [3] https://doc.wikimedia.org/oojs-ui/master/#!/api/OO.ui.WindowManager
That pretty much sums it up Jon, thanks for that.
My vision is that ideally VE standalone would work in mobile on it's own, and so the MW integration would be as light as possible: connecting up the load/save APIs and placing the VE instance in the right place.
Converting MF to OOUI widgets is also a great goal, and will make moving code between the the extensions a lot easier.
I'm CCing in Bartosz as he's doing great work on OOUI at the moment, and it would be great if he could work with mobile to make sure we have all the widgets and browser support tricks we need for touch devices.
On 27 January 2015 at 10:00, Jon Robson jrobson@wikimedia.org wrote:
Ideally all the existing code should live in VisualEditor and be based on OOJS UI. In the future we could also imagine the wikitext editor in mobile becoming part of the VisualEditor tool itself.
Sounds good – but let's talk about who's going to be doing this work and when :)
This quarter, we're planning to launch WikiGrok at 100% on enwiki and release a new pilot feature (Collections) on mobile web. Jon R will also be away for the month of February.
Jon: are you saying you want to commit to this work now, given what needs to get done on Collections + the experimental infobox editing stuff you've been doing in 20% time + your vacation time?
Ed & Bartosz, how much additional support would you need from a MFE frontend dev to make a standalone VE on mobile + MF --> OOUI widget conversion happen? 100%? A bit of help here and there? None?
My gut says that if the VE team needs more than limited ad hoc support from MFE engineers for this project, we should spend Q3 creating the backlog and do the work in Q4.
On Tue, Jan 27, 2015 at 10:22 AM, Ed Sanders esanders@wikimedia.org wrote:
That pretty much sums it up Jon, thanks for that.
My vision is that ideally VE standalone would work in mobile on it's own, and so the MW integration would be as light as possible: connecting up the load/save APIs and placing the VE instance in the right place.
Converting MF to OOUI widgets is also a great goal, and will make moving code between the the extensions a lot easier.
I'm CCing in Bartosz as he's doing great work on OOUI at the moment, and it would be great if he could work with mobile to make sure we have all the widgets and browser support tricks we need for touch devices.
On 27 January 2015 at 10:00, Jon Robson jrobson@wikimedia.org wrote:
Ideally all the existing code should live in VisualEditor and be based on OOJS UI. In the future we could also imagine the wikitext editor in mobile becoming part of the VisualEditor tool itself.
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
This will be a part time activity that will happen on the side managed via phabricator bugs. I do not anticipate this being a drastic amount of work, especially given the prior cleanup we have done in the MobileFrontend extension.
On Tue, Jan 27, 2015 at 11:12 AM, Maryana Pinchuk mpinchuk@wikimedia.org wrote:
Sounds good – but let's talk about who's going to be doing this work and when :)
This quarter, we're planning to launch WikiGrok at 100% on enwiki and release a new pilot feature (Collections) on mobile web. Jon R will also be away for the month of February.
Jon: are you saying you want to commit to this work now, given what needs to get done on Collections + the experimental infobox editing stuff you've been doing in 20% time + your vacation time?
Ed & Bartosz, how much additional support would you need from a MFE frontend dev to make a standalone VE on mobile + MF --> OOUI widget conversion happen? 100%? A bit of help here and there? None?
My gut says that if the VE team needs more than limited ad hoc support from MFE engineers for this project, we should spend Q3 creating the backlog and do the work in Q4.
On Tue, Jan 27, 2015 at 10:22 AM, Ed Sanders esanders@wikimedia.org wrote:
That pretty much sums it up Jon, thanks for that.
My vision is that ideally VE standalone would work in mobile on it's own, and so the MW integration would be as light as possible: connecting up the load/save APIs and placing the VE instance in the right place.
Converting MF to OOUI widgets is also a great goal, and will make moving code between the the extensions a lot easier.
I'm CCing in Bartosz as he's doing great work on OOUI at the moment, and it would be great if he could work with mobile to make sure we have all the widgets and browser support tricks we need for touch devices.
On 27 January 2015 at 10:00, Jon Robson jrobson@wikimedia.org wrote:
Ideally all the existing code should live in VisualEditor and be based on OOJS UI. In the future we could also imagine the wikitext editor in mobile becoming part of the VisualEditor tool itself.
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
-- Maryana Pinchuk Product Manager, Wikimedia Foundation wikimediafoundation.org
On Tue, 27 Jan 2015 11:12:27 -0800, Maryana Pinchuk mpinchuk@wikimedia.org wrote:
Ed & Bartosz, how much additional support would you need from a MFE frontend dev to make a standalone VE on mobile + MF --> OOUI widget conversion happen? 100%? A bit of help here and there? None?
I don't know, I'm not a mobile developer. What does mobile need that OOUI doesn't have? As far as I can tell everything should just work out of the box.
Jumping in here from experience: it was pretty weird to get proper hash routing (with back-button support) working with OOUI. Not *impossible*, but not incredibly obvious from the get-go since you still register routes via MFE, but also have to override teardowns of dialogs (the only component I'm familiar with, anyways). A quick example of some needed workarounds from the ZeroOverlay module in the ZeroBanner extension (sorry for no syntax highlighting):
45 ProcessDialog.prototype.getTeardownProcess = function ( data ) { 46 // Parent method 47 return ProcessDialog.super.prototype.getTeardownProcess.call( this, data ) 48 .first( function () { 49 if ( window.location.hash.indexOf('#/zerosite') > -1 || 50 window.location.hash.indexOf('#/zerofile') > -1 ) { 51 history.replaceState('', document.title, window.location.pathname + location.search); 52 } 53 }, this ); 54 };
In addition, there were some minor CSS overrides needed and I think a few other issues I can't recall at the moment.
Thanks,
Jeff Hobson
On Wed, Jan 28, 2015 at 1:06 PM, Bartosz Dziewoński < bdziewonski@wikimedia.org> wrote:
On Tue, 27 Jan 2015 11:12:27 -0800, Maryana Pinchuk < mpinchuk@wikimedia.org> wrote:
Ed & Bartosz, how much additional support would you need from a MFE
frontend dev to make a standalone VE on mobile + MF --> OOUI widget conversion happen? 100%? A bit of help here and there? None?
I don't know, I'm not a mobile developer. What does mobile need that OOUI doesn't have? As far as I can tell everything should just work out of the box.
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
I've setup T88559 to kick this off. This seems like the first logical step and has a clear "this is done" step. We will work out the other bugs as we go along.
https://phabricator.wikimedia.org/T88559
On Wed, Jan 28, 2015 at 4:30 PM, Jeff Hobson jhobson@wikimedia.org wrote:
Jumping in here from experience: it was pretty weird to get proper hash routing (with back-button support) working with OOUI. Not *impossible*, but not incredibly obvious from the get-go since you still register routes via MFE, but also have to override teardowns of dialogs (the only component I'm familiar with, anyways). A quick example of some needed workarounds from the ZeroOverlay module in the ZeroBanner extension (sorry for no syntax highlighting):
45 ProcessDialog.prototype.getTeardownProcess = function ( data ) { 46 // Parent method 47 return ProcessDialog.super.prototype.getTeardownProcess.call( this, data ) 48 .first( function () { 49 if ( window.location.hash.indexOf('#/zerosite') > -1 || 50 window.location.hash.indexOf('#/zerofile') > -1 ) { 51 history.replaceState('', document.title, window.location.pathname + location.search); 52 } 53 }, this ); 54 };
In addition, there were some minor CSS overrides needed and I think a few other issues I can't recall at the moment.
Thanks,
Jeff Hobson
On Wed, Jan 28, 2015 at 1:06 PM, Bartosz Dziewoński < bdziewonski@wikimedia.org> wrote:
On Tue, 27 Jan 2015 11:12:27 -0800, Maryana Pinchuk < mpinchuk@wikimedia.org> wrote:
Ed & Bartosz, how much additional support would you need from a MFE
frontend dev to make a standalone VE on mobile + MF --> OOUI widget conversion happen? 100%? A bit of help here and there? None?
I don't know, I'm not a mobile developer. What does mobile need that OOUI doesn't have? As far as I can tell everything should just work out of the box.
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l