Hi Vibha,
I modified the "external link" indicator for Night mode. Here's how it looks: https://www.dropbox.com/s/8sebxpjqee02wha/device-2014-07-17-113418.png
I simply took the existing indicator and made its background transparent, instead of white. Technically, since it's transparent now, it can replace the indicator in our general styles, so that we wouldn't need a different one for night mode. Thoughts?
-Dmitry
There's no real user-facing change if we do this, so we're good to go on my end.
Dan
On 17 July 2014 08:54, Dmitry Brant dbrant@wikimedia.org wrote:
Hi Vibha,
I modified the "external link" indicator for Night mode. Here's how it looks: https://www.dropbox.com/s/8sebxpjqee02wha/device-2014-07-17-113418.png
I simply took the existing indicator and made its background transparent, instead of white. Technically, since it's transparent now, it can replace the indicator in our general styles, so that we wouldn't need a different one for night mode. Thoughts?
-Dmitry
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
This is definitely an improvement. It doesn't stick out as much now. Thanks Dmitri. Good to go!
---- Vibha Bamba Senior Designer | WMF Design
On Thu, Jul 17, 2014 at 9:25 AM, Dan Garry dgarry@wikimedia.org wrote:
There's no real user-facing change if we do this, so we're good to go on my end.
Dan
On 17 July 2014 08:54, Dmitry Brant dbrant@wikimedia.org wrote:
Hi Vibha,
I modified the "external link" indicator for Night mode. Here's how it looks: https://www.dropbox.com/s/8sebxpjqee02wha/device-2014-07-17-113418.png
I simply took the existing indicator and made its background transparent, instead of white. Technically, since it's transparent now, it can replace the indicator in our general styles, so that we wouldn't need a different one for night mode. Thoughts?
-Dmitry
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
-- Dan Garry Associate Product Manager for Platform and Mobile Apps Wikimedia Foundation