(Replying on list, I assume it was just my reply-to's fault.)
Quim Gil, 05/04/2014 07:41:
On Tue, Apr 1, 2014 at 1:24 PM, Federico Leva (Nemo) nemowiki@gmail.com wrote:
Once again, please just use core's style. There was a huge discussion about it back then, there is no need to reinvent the wheel and reopen flames.
I'll say it once, and then I'll go back to minding my own business. :)
Not using the red-green convention actually sounds like trying to reinvent the wheel.
Possible. However, if it was such a big problem in core, it should be addressed there and not just circumvented.
No, I wasn't here when that long discussion happen, no I haven't read the archives. I just look what everybody else is doing nowadays in diff land. Could you run that blind simulator against the conventional red-green combination (see links below) to see how it performs against the current colors used in MediaWiki core? Just to know the results.
In fact my only complaint against the red-green approach taken by the Mobile team is that they chose their own red-green contrast, a lot stronger than what is usually found elsewhere.
The colors used in core are difficult to read compared to the average red-green schema found elsewhere. I'm not even talking about users with special needs. I just need my own eyes with not the best laptop or desktop monitors, not in the perfect angle of view, or not with the best light conditions. This happens already with regular text, when it comes to white spaces it is so bad that I filed https://bugzilla.wikimedia.org/show_bug.cgi?id=59093
That's really unrelated from the colours change. In fact, small diffs were completely invisibile with the old style. See also the quotation at https://www.mediawiki.org/wiki/MediaWiki_1.20#Diff
Nemo
Samples:
GitHub, Gerrit, and Phabricator use the same colors more or less:
https://github.com/wikimedia/mediawiki-core/commit/811b2e613861a2cc9c6c09eb0...
https://gerrit.wikimedia.org/r/#/c/118761/4/README
Meanwhile, in MediaWiki desktop and mobile...
https://www.mediawiki.org/w/index.php?title=User%3AQgil%2FSandbox&diff=9...
https://m.mediawiki.org/wiki/Special:MobileDiff/949852...949853
Samples from other services are welcome.