After reading benefits of CSSLint there is no doubt in my mind that we should use it. Here [1] are some of the benefits. They range from possible errors to compatibility to performance, etc. With grunt we can use grunt-lesslint [2], which employs CSSLint under the hood so we can also tweak it using CSSLint rules.
What do you guys think?
[1] https://github.com/CSSLint/csslint/wiki/Rules https://github.com/CSSLint/csslint/wiki/Rules. [2] https://github.com/jgable/grunt-lesslint https://github.com/jgable/grunt-lesslint
Which rules would MobileFrontend be able to use from the start? Which rules might be controversial to adopt?
On Fri, Nov 21, 2014 at 9:00 AM, Bahodir Mansurov bmansurov@wikimedia.org wrote:
After reading benefits of CSSLint there is no doubt in my mind that we should use it. Here [1] are some of the benefits. They range from possible errors to compatibility to performance, etc. With grunt we can use grunt-lesslint [2], which employs CSSLint under the hood so we can also tweak it using CSSLint rules.
What do you guys think?
[1] https://github.com/CSSLint/csslint/wiki/Rules. [2] https://github.com/jgable/grunt-lesslint
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
CSS is a beast and any help is going to be useful.
As Jon said, we probably need a longer spike/task to see if any other teams are doing CSS linting and there are already conventions we can use, and to determine what validation rules we want to use. El 21/11/2014 2:53, "Jon Robson" jrobson@wikimedia.org escribió:
Which rules would MobileFrontend be able to use from the start? Which rules might be controversial to adopt?
On Fri, Nov 21, 2014 at 9:00 AM, Bahodir Mansurov bmansurov@wikimedia.org wrote:
After reading benefits of CSSLint there is no doubt in my mind that we should use it. Here [1] are some of the benefits. They range from
possible
errors to compatibility to performance, etc. With grunt we can use grunt-lesslint [2], which employs CSSLint under the hood so we can also tweak it using CSSLint rules.
What do you guys think?
[1] https://github.com/CSSLint/csslint/wiki/Rules. [2] https://github.com/jgable/grunt-lesslint
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Here are our [1] LESS code conventions. Basically, CSSLint doesn’t support any of our existing conventions. It’s more concerned about errors, compatibility, and performance. Our rules are mainly about syntax. We could write (in JavaScript) CSSLint rules to support our current code conventions though. Here [2] are some custom rules.
Since our code convention doesn’t talk about the existing CSSLint rules [3], in order to figure out which rules are controversial I think we should all discuss the existing rules [3].
Also, the VE team uses CSSLint; possibly other teams too. However, I don’t think any team is using lesslint.
[1] http://www.mediawiki.org/wiki/Manual:Coding_conventions/CSS#LESS http://www.mediawiki.org/wiki/Manual:Coding_conventions/CSS#LESS [2] https://github.com/medikoo/csslint-next/tree/master/rules https://github.com/medikoo/csslint-next/tree/master/rules [3] https://github.com/CSSLint/csslint/wiki/Rules https://github.com/CSSLint/csslint/wiki/Rules
On Nov 21, 2014, at 3:45 AM, Joaquin Oltra Hernandez jhernandez@wikimedia.org wrote:
CSS is a beast and any help is going to be useful.
As Jon said, we probably need a longer spike/task to see if any other teams are doing CSS linting and there are already conventions we can use, and to determine what validation rules we want to use.
El 21/11/2014 2:53, "Jon Robson" <jrobson@wikimedia.org mailto:jrobson@wikimedia.org> escribió: Which rules would MobileFrontend be able to use from the start? Which rules might be controversial to adopt?
On Fri, Nov 21, 2014 at 9:00 AM, Bahodir Mansurov <bmansurov@wikimedia.org mailto:bmansurov@wikimedia.org> wrote:
After reading benefits of CSSLint there is no doubt in my mind that we should use it. Here [1] are some of the benefits. They range from possible errors to compatibility to performance, etc. With grunt we can use grunt-lesslint [2], which employs CSSLint under the hood so we can also tweak it using CSSLint rules.
What do you guys think?
[1] https://github.com/CSSLint/csslint/wiki/Rules https://github.com/CSSLint/csslint/wiki/Rules. [2] https://github.com/jgable/grunt-lesslint https://github.com/jgable/grunt-lesslint
Mobile-l mailing list Mobile-l@lists.wikimedia.org mailto:Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l https://lists.wikimedia.org/mailman/listinfo/mobile-l
Mobile-l mailing list Mobile-l@lists.wikimedia.org mailto:Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l https://lists.wikimedia.org/mailman/listinfo/mobile-l
Can CSSLint be run on less code though, or will we have to generate load.php urls and run it there?
is there any advantage to using lesslint / any reason we wouldn't use it?
On Sat, Nov 22, 2014 at 5:12 AM, Bahodir Mansurov bmansurov@wikimedia.org wrote:
Here are our [1] LESS code conventions. Basically, CSSLint doesn’t support any of our existing conventions. It’s more concerned about errors, compatibility, and performance. Our rules are mainly about syntax. We could write (in JavaScript) CSSLint rules to support our current code conventions though. Here [2] are some custom rules.
Since our code convention doesn’t talk about the existing CSSLint rules [3], in order to figure out which rules are controversial I think we should all discuss the existing rules [3].
Also, the VE team uses CSSLint; possibly other teams too. However, I don’t think any team is using lesslint.
[1] http://www.mediawiki.org/wiki/Manual:Coding_conventions/CSS#LESS [2] https://github.com/medikoo/csslint-next/tree/master/rules [3] https://github.com/CSSLint/csslint/wiki/Rules
On Nov 21, 2014, at 3:45 AM, Joaquin Oltra Hernandez jhernandez@wikimedia.org wrote:
CSS is a beast and any help is going to be useful.
As Jon said, we probably need a longer spike/task to see if any other teams are doing CSS linting and there are already conventions we can use, and to determine what validation rules we want to use.
El 21/11/2014 2:53, "Jon Robson" jrobson@wikimedia.org escribió:
Which rules would MobileFrontend be able to use from the start? Which rules might be controversial to adopt?
On Fri, Nov 21, 2014 at 9:00 AM, Bahodir Mansurov bmansurov@wikimedia.org wrote:
After reading benefits of CSSLint there is no doubt in my mind that we should use it. Here [1] are some of the benefits. They range from possible errors to compatibility to performance, etc. With grunt we can use grunt-lesslint [2], which employs CSSLint under the hood so we can also tweak it using CSSLint rules.
What do you guys think?
[1] https://github.com/CSSLint/csslint/wiki/Rules. [2] https://github.com/jgable/grunt-lesslint
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
There is lesslint for running on less code. It uses CSSLint under the hood. I don’t think CSSLint can be run on less code.
On Nov 23, 2014, at 7:38 PM, Jon Robson jrobson@wikimedia.org wrote:
Can CSSLint be run on less code though, or will we have to generate load.php urls and run it there?
is there any advantage to using lesslint / any reason we wouldn't use it?
On Sat, Nov 22, 2014 at 5:12 AM, Bahodir Mansurov bmansurov@wikimedia.org wrote:
Here are our [1] LESS code conventions. Basically, CSSLint doesn’t support any of our existing conventions. It’s more concerned about errors, compatibility, and performance. Our rules are mainly about syntax. We could write (in JavaScript) CSSLint rules to support our current code conventions though. Here [2] are some custom rules.
Since our code convention doesn’t talk about the existing CSSLint rules [3], in order to figure out which rules are controversial I think we should all discuss the existing rules [3].
Also, the VE team uses CSSLint; possibly other teams too. However, I don’t think any team is using lesslint.
[1] http://www.mediawiki.org/wiki/Manual:Coding_conventions/CSS#LESS [2] https://github.com/medikoo/csslint-next/tree/master/rules [3] https://github.com/CSSLint/csslint/wiki/Rules
On Nov 21, 2014, at 3:45 AM, Joaquin Oltra Hernandez jhernandez@wikimedia.org wrote:
CSS is a beast and any help is going to be useful.
As Jon said, we probably need a longer spike/task to see if any other teams are doing CSS linting and there are already conventions we can use, and to determine what validation rules we want to use.
El 21/11/2014 2:53, "Jon Robson" jrobson@wikimedia.org escribió:
Which rules would MobileFrontend be able to use from the start? Which rules might be controversial to adopt?
On Fri, Nov 21, 2014 at 9:00 AM, Bahodir Mansurov bmansurov@wikimedia.org wrote:
After reading benefits of CSSLint there is no doubt in my mind that we should use it. Here [1] are some of the benefits. They range from possible errors to compatibility to performance, etc. With grunt we can use grunt-lesslint [2], which employs CSSLint under the hood so we can also tweak it using CSSLint rules.
What do you guys think?
[1] https://github.com/CSSLint/csslint/wiki/Rules. [2] https://github.com/jgable/grunt-lesslint
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l