Kaldari, do you need legal review for messaging at all?
On Wed, Mar 26, 2014 at 12:09 PM, Tomasz Finc tfinc@wikimedia.org wrote:
Moving to mobile-l
On Wed, Mar 26, 2014 at 12:05 PM, Ryan Kaldari rkaldari@wikimedia.org wrote:
Whenever someone decides to review the new licensing stuff in mobile,
let me
know. It requires updating both MobileFrontend and WikimediaMessages, and takes a fair bit of work to test all the combinations and interfaces.
The 5 interfaces are:
- Wikitext editor
- VisualEditor
- Talk page add new section
- Talk page add new comment to section
- Upload file
The variables for the combinations are:
- WikimediaMessages on or off
- $wgRightsUrl set or not set
- $wgRightsText set to various licenses (cc-by-sa has special importance
for
WikimediaMessages)
- Terms of Use set or not set
- $wgRightsPage set or not set
- Various i18n messages overridden locally
I can help whoever is reviewing to walk through these. I didn't write acceptance tests since the functionality is non-critical (it's basically been broken for years), and it would require a shitload of tests to test effectively. If someone thinks it should have acceptance tests though,
let
me know.
Ryan Kaldari
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l