Change looks good and I've merged it, but if we need to push it in a hurry we'll still need to arrange an LD or SWAT.
-- brion
On Thu, Jun 5, 2014 at 6:13 AM, Liangent liangent@gmail.com wrote:
I think https://gerrit.wikimedia.org/r/#/c/137563/ fixes this.
-Liangent
On Thu, Jun 5, 2014 at 11:30 AM, Dario Taraborelli dtaraborelli@wikimedia.org wrote:
This afternoon Dan and I reviewed how tags from the android app are
captured
in the change_tag and tag_summary tables.
(1) We noticed that the “mobile app edit” tag is applied to recentchanges events that are not edits, but new account registrations:
SELECT * FROM enwiki.change_tag WHERE ct_rev_id IS NULL AND ct_tag =
"mobile
app edit";
ct_rc_id ct_log_id ct_rev_id ct_tag ct_params 661123291 56899294 NULL mobile app edit NULL 661123407 56899301 NULL mobile app edit NULL 661124928 56899375 NULL mobile app edit NULL 661127933 56899610 NULL mobile app edit NULL 661128644 56899685 NULL mobile app edit NULL 661131626 56899908 NULL mobile app edit NULL 661133278 56899998 NULL mobile app edit NULL 661134572 56900072 NULL mobile app edit NULL 661140653 56900620 NULL mobile app edit NULL 661155198 56901558 NULL mobile app edit NULL 661155799 56901593 NULL mobile app edit NULL 661156983 56901659 NULL mobile app edit NULL
AFAIK this is unusual behavior for tags and will create artifacts in
tagged
revisions unless people are aware that all these registration-related
events
always need to be excluded (it’s also confusing because the name of the
tag
explicitly refers to an edit). As suggested earlier [1], we should not
track
the source of account registrations via MediaWiki tags but via the ServerSideAccountCreation log.
(2) edits made on apps should be stored with two separate tags: “mobile edit” and “mobile app edit”. The tags are correctly stored in the
change_tag
table with 2 records for each revisions, e.g.
SELECT * FROM enwiki.change_tag WHERE ct_rc_id = 661110028;
ct_rc_id ct_log_id ct_rev_id ct_tag ct_params 661110028 NULL 611585155 mobile app edit NULL 661110028 NULL 611585155 mobile edit NULL
but when the tags are combined in the tag_summary table, the “mobile app edit” tag is lost:
SELECT * FROM enwiki.tag_summary WHERE ts_rc_id = 661110028;
ts_rc_id ts_log_id ts_rev_id ts_tags 661110028 NULL 611585155 mobile edit
This should not be the case, the 2 tags should be concatenated in the ts_tags field, see for example this desktop revision with 2 tags:
SELECT * FROM enwiki.change_tag WHERE ct_rc_id = 578489188;
ct_rc_id ct_log_id ct_rev_id ct_tag ct_params 578489188 NULL 555564321 gettingstarted edit NULL 578489188 NULL 555564321 visualeditor NULL
SELECT * FROM enwiki.tag_summary WHERE ts_rc_id = 578489188;
ts_rc_id ts_log_id ts_rev_id ts_tags 578489188 NULL 555564321 gettingstarted edit,visualeditor
I believe that neither (1) nor (2) is intended behavior for apps. Can you guys confirm and if so, can we fix this?
Dario
[1] http://lists.wikimedia.org/pipermail/mobile-l/2014-May/007150.html
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l