Nearby already has pretty complete unit tests, but these appear to be working inadequately... Usually the things that break are simply loading it in the first place which can really only be tested with a browser test.
On Tue, Mar 18, 2014 at 11:46 AM, Chris McMahon cmcmahon@wikimedia.org wrote:
On Tue, Mar 18, 2014 at 11:36 AM, Jon Robson jrobson@wikimedia.org wrote:
Moving to mobile-l
Setting the cookie mf_useformat ensures that the mobile site gets loaded. If tests are run against en.m. etc.. this won't have any effect, but a lot of local instances are setup to run the desktop URL by default. An alternative way of doing this would be to toggle to the mobile site explicitly in the test suite.
I guess I thought it was redundant because of the line in url_module.rb ""#{mediawiki_url}#{name}?useformat=mobile"" accomplishes the same thing. Although maybe you need the cookie if you follow a link out to a new URL? Just guessing.
In terms of 2nd question - no I don't think we should abandon trying to test Nearby in the browser, it is one of our most important features and has extremely inadequate test coverage and is one of the things that seems to break the most. Even if the test only works for Firefox, having that test is a good thing.
Does anyone think this would be better tested below the UI level?
-Chris
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l