I've setup T88559 to kick this off. This seems like the first logical step and has a clear "this is done" step. We will work out the other bugs as we go along.
https://phabricator.wikimedia.org/T88559
On Wed, Jan 28, 2015 at 4:30 PM, Jeff Hobson jhobson@wikimedia.org wrote:
Jumping in here from experience: it was pretty weird to get proper hash routing (with back-button support) working with OOUI. Not *impossible*, but not incredibly obvious from the get-go since you still register routes via MFE, but also have to override teardowns of dialogs (the only component I'm familiar with, anyways). A quick example of some needed workarounds from the ZeroOverlay module in the ZeroBanner extension (sorry for no syntax highlighting):
45 ProcessDialog.prototype.getTeardownProcess = function ( data ) { 46 // Parent method 47 return ProcessDialog.super.prototype.getTeardownProcess.call( this, data ) 48 .first( function () { 49 if ( window.location.hash.indexOf('#/zerosite') > -1 || 50 window.location.hash.indexOf('#/zerofile') > -1 ) { 51 history.replaceState('', document.title, window.location.pathname + location.search); 52 } 53 }, this ); 54 };
In addition, there were some minor CSS overrides needed and I think a few other issues I can't recall at the moment.
Thanks,
Jeff Hobson
On Wed, Jan 28, 2015 at 1:06 PM, Bartosz Dziewoński < bdziewonski@wikimedia.org> wrote:
On Tue, 27 Jan 2015 11:12:27 -0800, Maryana Pinchuk < mpinchuk@wikimedia.org> wrote:
Ed & Bartosz, how much additional support would you need from a MFE
frontend dev to make a standalone VE on mobile + MF --> OOUI widget conversion happen? 100%? A bit of help here and there? None?
I don't know, I'm not a mobile developer. What does mobile need that OOUI doesn't have? As far as I can tell everything should just work out of the box.
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l