Is anyone experiencing issues with alignment of new-style <figure> thumbnails with Foreground on MediaWiki 1.40? I'm confused because this wiki hasn't been touched for ages and thumbnails were working last I looked (or maybe they weren't!), but now they're not floating, e.g.: https://freo.wiki/Street_names_-_words_which_clash_on_the_phone.
I'll of course file a bug report but I thought I'd just ask.
There was one with Pivot https://www.mediawiki.org/wiki/Topic:Xxs4wup6jfeol6bp and this sounds much like Foreground suffers from it, too.
Karsten / MediaWiki and Semantic MediaWiki enthusiast
https://professional.wiki // https://www.pro.wiki
Am 15.06.24 um 04:17 schrieb Sam Wilson:
Is anyone experiencing issues with alignment of new-style <figure> thumbnails with Foreground on MediaWiki 1.40? I'm confused because this wiki hasn't been touched for ages and thumbnails were working last I looked (or maybe they weren't!), but now they're not floating, e.g.: https://freo.wiki/Street_names_-_words_which_clash_on_the_phone.
I'll of course file a bug report but I thought I'd just ask.
Foreground mailing list -- foreground@lists.wikimedia.org To unsubscribe send an email to foreground-leave@lists.wikimedia.org
Thanks! That makes sense.
So this might do it? https://gerrit.wikimedia.org/r/c/mediawiki/skins/Foreground/+/1045398
On 15/6/24 21:31, [[kgh]] wrote:
There was one with Pivot https://www.mediawiki.org/wiki/Topic:Xxs4wup6jfeol6bp and this sounds much like Foreground suffers from it, too.
Karsten / MediaWiki and Semantic MediaWiki enthusiast
https://professional.wiki // https://www.pro.wiki
Am 15.06.24 um 04:17 schrieb Sam Wilson:
Is anyone experiencing issues with alignment of new-style <figure> thumbnails with Foreground on MediaWiki 1.40? I'm confused because this wiki hasn't been touched for ages and thumbnails were working last I looked (or maybe they weren't!), but now they're not floating, e.g.: https://freo.wiki/Street_names_-_words_which_clash_on_the_phone.
I'll of course file a bug report but I thought I'd just ask.
Foreground mailing list -- foreground@lists.wikimedia.org To unsubscribe send an email to foreground-leave@lists.wikimedia.org
Foreground mailing list -- foreground@lists.wikimedia.org To unsubscribe send an email to foreground-leave@lists.wikimedia.org
I'd say yes given the fix that Jon added to Pivot: https://github.com/wikimedia/mediawiki-skins-Pivot/commit/4c70d1b5f66d31b9a1... I currently have on 1.41 at hand to do a field test.
Karsten / MediaWiki and Semantic MediaWiki enthusiast
https://professional.wiki // https://www.pro.wiki
Am 16.06.24 um 05:08 schrieb Sam Wilson:
Thanks! That makes sense.
So this might do it? https://gerrit.wikimedia.org/r/c/mediawiki/skins/Foreground/+/1045398
On 15/6/24 21:31, [[kgh]] wrote:
There was one with Pivot https://www.mediawiki.org/wiki/Topic:Xxs4wup6jfeol6bp and this sounds much like Foreground suffers from it, too.
Karsten / MediaWiki and Semantic MediaWiki enthusiast
https://professional.wiki // https://www.pro.wiki
Am 15.06.24 um 04:17 schrieb Sam Wilson:
Is anyone experiencing issues with alignment of new-style <figure> thumbnails with Foreground on MediaWiki 1.40? I'm confused because this wiki hasn't been touched for ages and thumbnails were working last I looked (or maybe they weren't!), but now they're not floating, e.g.: https://freo.wiki/Street_names_-_words_which_clash_on_the_phone.
I'll of course file a bug report but I thought I'd just ask.
Foreground mailing list -- foreground@lists.wikimedia.org To unsubscribe send an email to foreground-leave@lists.wikimedia.org
Foreground mailing list -- foreground@lists.wikimedia.org To unsubscribe send an email to foreground-leave@lists.wikimedia.org
Foreground mailing list -- foreground@lists.wikimedia.org To unsubscribe send an email to foreground-leave@lists.wikimedia.org
Jon merged my patch, and all seems well now. If anyone finds this to break something, let me know.
On 18/6/24 03:27, [[kgh]] wrote:
I'd say yes given the fix that Jon added to Pivot: https://github.com/wikimedia/mediawiki-skins-Pivot/commit/4c70d1b5f66d31b9a1... I currently have on 1.41 at hand to do a field test.
Karsten / MediaWiki and Semantic MediaWiki enthusiast
https://professional.wiki // https://www.pro.wiki
Am 16.06.24 um 05:08 schrieb Sam Wilson:
Thanks! That makes sense.
So this might do it? https://gerrit.wikimedia.org/r/c/mediawiki/skins/Foreground/+/1045398
On 15/6/24 21:31, [[kgh]] wrote:
There was one with Pivot https://www.mediawiki.org/wiki/Topic:Xxs4wup6jfeol6bp and this sounds much like Foreground suffers from it, too.
Karsten / MediaWiki and Semantic MediaWiki enthusiast
https://professional.wiki // https://www.pro.wiki
Am 15.06.24 um 04:17 schrieb Sam Wilson:
Is anyone experiencing issues with alignment of new-style <figure> thumbnails with Foreground on MediaWiki 1.40? I'm confused because this wiki hasn't been touched for ages and thumbnails were working last I looked (or maybe they weren't!), but now they're not floating, e.g.: https://freo.wiki/Street_names_-_words_which_clash_on_the_phone.
I'll of course file a bug report but I thought I'd just ask.
Foreground mailing list -- foreground@lists.wikimedia.org To unsubscribe send an email to foreground-leave@lists.wikimedia.org
Foreground mailing list -- foreground@lists.wikimedia.org To unsubscribe send an email to foreground-leave@lists.wikimedia.org
Foreground mailing list -- foreground@lists.wikimedia.org To unsubscribe send an email to foreground-leave@lists.wikimedia.org
Foreground mailing list -- foreground@lists.wikimedia.org To unsubscribe send an email to foreground-leave@lists.wikimedia.org
foreground@lists.wikimedia.org