Hi everyone,
We're cleaning out the commit access request queue, and came upon a request for commit access to pywikipediabot. Two questions: 1. How should we generally vet these requests? 2. The access request is from this person: http://www.mediawiki.org/wiki/User:Ebraminio Any objections to granting access for this person?
I'm "robla" on IRC, and I'm currently camped out in #pywikipediabot if you'd like to ping me to discuss further.
Thanks Rob
2010/12/31 Rob Lanphier robla@wikimedia.org
- The access request is from this person:
http://www.mediawiki.org/wiki/User:Ebraminio Any objections to granting access for this person?
3 patches on SF (http://sourceforge.net/users/ebraminio/) and never seen
on this mailing list.
So, I've been talking to robla, Multichil and briefly betacommand on IRC today, and here are some of the ideas we came up (while talking about me possibly requesting commit to pywikipediabot) with, full logs below that...
* Be active on the IRC channel or mailing list and have submitted a few good patches via Sourceforge or other methods. * Keep it flexible, don't get strict on commit access, we haven't been up before. It'd be nice to see a flow of new developers. * Gained community consensus via the mailing list. "The request for commit access can be simultaneous with the mail to the mailing list"
These are just ideas, and of course, can still be expanded or fine-tuned.
-- _My Request_
Basicly, if I get consensus from this post on my request for commit, I'll submit a request for commit access via the correct email address. As you'll see in the logs below, I'm basicly interested at this point in time in maintaining the non-WMF family files in the SVN, and working on the i18n translation that I hear you guys are planning to work on rather soon. As a member of the translatewiki.net staff, and an active user of pywikipediabot, I think it'd be nice to help out there.
I've submitted a few patches via IRC before which have been commited, and been active in the community, in the IRC channel and have probably posted to the mailing lists (don't have time to dig that up now) a few times, despite being subscribed for a long time.
--_ IRC Logs_
[16:52:22] <Lcawte> robla: so, any news on pybot commit? What are the ideas so far? I've only seen the mailing list ones [16:53:18] <robla> Lcawte: so, in this case, I think I'll ask the person asking for access to say "hi" on the mailing list [16:53:36] <robla> as for a generalized process, I'm not sure [16:53:40] <Lcawte> Hm... [16:54:27] <robla> (to be clear, asking him to say "hi" and not granting svn access yet) [16:57:13] <Delta> robla: Id probably not grant access [17:04:55] <Lcawte> Delta: any idea of what you'd like to see as requirements for pybot commit? [17:07:18] <Delta> Lcawte: several good patches and active with either the mailing list/bug system/ or this channel [17:07:24] <Multichil> Lcawte : Do you want access? [17:10:13] <Lcawte> Active in this channel, thats mainly bots and the odd occasional person when someone shows up for help [17:10:20] <Lcawte> Multichil: yeah :P [17:10:42] <Multichil> Anything in particulair? Maybe getting it translated? [17:11:52] <Lcawte> I'd be happy to help whoever else wants to work on that as well, yeah, maintaining family files, I've submitted a few minor patches, if that means a few lines of code changed, one fixed a script completely, the other added mainly Wikia support to a script (timestamps) [17:12:07] <Lcawte> (the patches were through this channel) [17:13:40] <Multichil> Lcawte : Next week we're planning on adding pywikipedia to translatewiki :-) That's why I'm asking [17:14:07] <Multichil> You're not a totall strange to the community so why not? [17:14:40] <Lcawte> I know a few people are interesting with helping with that, so I'll be around and offering to help if people want [17:14:47] <Multichil> We've never been really strict, no need to become strict now [17:14:57] <Lcawte> I think Siebrand is interested in helping with it as well, not sure though [17:15:25] <Multichil> He will also be there, Gerard too [17:15:42] <Multichil> http://nl.wikimedia.org/wiki/Hackathon#Mensen [17:16:17] <Lcawte> Thank goodness, because someone needs commit to extensions so they can commit the Translate config [17:23:10] <Lcawte> Multichil, robla, what do you recommend, as there is no vetting procedure currently in place, start a post on the mailing list and if theres a fair consensus, request it? [17:24:19] <robla> Lcawte: that sounds good to me [17:24:28] <Multichil> robla : Don't bother, just give him access ;-) [17:24:31] <Lcawte> lol [17:24:57] <Multichil> Too much red tape with the same end result anyway [17:27:01] <Lcawte> The only problem with requesting it, is I have to get past Tim, I think he has auto-deny on my requests, or atleast with extensions lol... I get he would like some decent lines of code from me and all, but its kinda getting a pain in the butt not having it for translatewiki.net and stuff... (MediaWiki r79535, r79534, 79533 and 79531... and theres another one earlier than that.. [17:51:22] <robla> so, I don't know any of the history here. I like what Lcawte is suggesting with maybe one minor tweak. the request for commit access can be simultaneous with the mail to the mailing list [17:53:42] <robla> Tim's concern last time I spoke to him about this was just that he just didn't have a good sense of the pywikipediabot community, so it was tough for him to make the call [17:55:46] <Lcawte> Mm, kinda like my discussion about pybot commit for my first extensions commit request [17:56:52] <Lcawte> I wonder, what family files are out of date... :/ [18:01:51] <Lcawte> [17:59:34] <Lcawte> Hm, the i18n family needs updating.. its missing a namespace or two, I know it is, because I added one yesterday :P [18:13:53] <Lcawte> Well, theres more than one out of date family file :| [18:20:41] <Lcawte> robla: shall I email these ideas to the list? [18:21:08] <robla> Lcawte: yeah, that'd be great
--
Thanks, Lewis Cawte
On 30/12/10 23:57, Rob Lanphier wrote:
Hi everyone,
We're cleaning out the commit access request queue, and came upon a request for commit access to pywikipediabot. Two questions:
- How should we generally vet these requests?
- The access request is from this person:
http://www.mediawiki.org/wiki/User:Ebraminio Any objections to granting access for this person?
I'm "robla" on IRC, and I'm currently camped out in #pywikipediabot if you'd like to ping me to discuss further.
Thanks Rob
Pywikipedia-l mailing list Pywikipedia-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l
Hi all,
Lewis asked me on IRC to reply, so a short reaction.
On 4 January 2011 19:36, Lewis Cawte lewiscawte@googlemail.com wrote:
- Be active on the IRC channel or mailing list and have submitted a few good
patches via Sourceforge or other methods.
- Keep it flexible, don't get strict on commit access, we haven't been up
before. It'd be nice to see a flow of new developers.
- Gained community consensus via the mailing list. "The request for commit
access can be simultaneous with the mail to the mailing list"
I would change community consensus to 'no objection'. It's OK if code quality isn't perfect, it just shouldn't be horrible.
Additionally, 'submitted a few good patches' really depends on what the person wants to do. In general, I'm OK with giving anyone access, as long as the person is reactive to comments on his/hers commits. This is, IMO, reallly more important than having lots of patches submitted.
Last, but not least - people who have access to the other repositories on svn.wikimedia.org also have access to the pwb repository. I think it would be a good idea to give these people 'official' access - i.e. if you commit to mediawiki, you're allowed to commit to pywikipediabot, too.
Best regards, Merlijn
Hi everyone,
Sorry for letting this one sit on the backburner for a while. Replying to Merlijn's mail:
On Fri, Jan 7, 2011 at 11:01 AM, Merlijn van Deen valhallasw@arctus.nl wrote:
Lewis asked me on IRC to reply, so a short reaction.
On 4 January 2011 19:36, Lewis Cawte lewiscawte@googlemail.com wrote:
- Be active on the IRC channel or mailing list and have submitted a few good
patches via Sourceforge or other methods.
- Keep it flexible, don't get strict on commit access, we haven't been up
before. It'd be nice to see a flow of new developers.
- Gained community consensus via the mailing list. "The request for commit
access can be simultaneous with the mail to the mailing list"
I would change community consensus to 'no objection'. It's OK if code quality isn't perfect, it just shouldn't be horrible.
I'm not sure I'm comfortable with such a low bar. I'd like to know a list of core committers, any one of which could give a "+1" for someone, and so long as there isn't an objection from anyone else after a fixed period (for example: 4 days), we'd grant access. Ideally, the list of core committers would actually live in a text file in the SVN repository.
Alternatively, if there was someone in the community that the core committers approve to be the person that vets access requests, that works for us as well.
Also, we need to figure out who makes the call when someone requests that we revoke the access for someone else. Having that information live in the aforementioned core committers list would be ideal.
Rob
Hi Rob,
On 20 January 2011 18:55, Rob Lanphier robla@wikimedia.org wrote:
I'm not sure I'm comfortable with such a low bar. I'd like to know a list of core committers, any one of which could give a "+1" for someone, and so long as there isn't an objection from anyone else after a fixed period (for example: 4 days), we'd grant access. Ideally, the list of core committers would actually live in a text file in the SVN repository.
This makes sense. The currently active committers would probably be xqt, multichill and myself. Purodha and siebrand are less active. I have no idea how busy xqt is, but for multichill, siebrand and myself I think I can argue we are quite busy. This means even replying to this e-mail took me a while - actually checking commit access requests probably takes an even longer time.
However, we do read commit logs. This means granting access and complaining afterwards is easier for us - but of course not for you, as server administrator ;-)
Anyway, I think the +1 system might be the best 'polder'solution[1]. As such, I'll reply to your mail about Lewis shortly.
Thanks, Merlijn
2011/1/22 Merlijn van Deen valhallasw@arctus.nl
However, we do read commit logs. This means granting access and complaining afterwards is easier for us
This was really a native Pythonic answer. :-DDD (It is Easier to Ask for Forgiveness than Permission.http://en.wikipedia.org/wiki/Python_syntax_and_semantics#Exceptions )
Hello
By the way - I should also be on this list, since I requested (ages ago) commit access. The last commits were all done by xqt, which could probabliy get annoyed in doing my job... ;)
Greetings
Am 31.12.2010 00:57, schrieb Rob Lanphier:
Hi everyone,
We're cleaning out the commit access request queue, and came upon a request for commit access to pywikipediabot. Two questions:
- How should we generally vet these requests?
- The access request is from this person:
http://www.mediawiki.org/wiki/User:Ebraminio Any objections to granting access for this person?
I'm "robla" on IRC, and I'm currently camped out in #pywikipediabot if you'd like to ping me to discuss further.
Thanks Rob
Pywikipedia-l mailing list Pywikipedia-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l
Do you think I could request an access? I work much with replace.py, and I have often ideas to improve it.
As we're talking about commit access anyway - I _think_ I have commit access, but I have no idea where and how I can commit... Can anyone enlighten me?
On 16/01/11 11:36, Andre Engels wrote:
As we're talking about commit access anyway - I _think_ I have commit access, but I have no idea where and how I can commit... Can anyone enlighten me?
O.o
A commiter with no idea how to commit... strange...
Anyway, I'd take a look at http://www.mediawiki.org/wiki/Commit_access (its a bit mediawiki specific, so just adapt what you do to the pywikipediabot settings).
It looks like you have commit access, as you have a USERINFO file, http://svn.wikimedia.org/viewvc/mediawiki/USERINFO/a_engels?revision=75020&a...
Thanks, - Lewis Cawte
2011/1/16 Andre Engels andreengels@gmail.com
As we're talking about commit access anyway - I _think_ I have commit access, but I have no idea where and how I can commit... Can anyone enlighten me?
But you *have* *solved* a problem I reported, do you remember?
http://svn.wikimedia.org/viewvc/pywikipedia/trunk/pywikipedia/userinterfaces... Try to descend to alpha and remember, how did you do that. :-)
On Sun, Jan 16, 2011 at 1:10 PM, Bináris wikiposta@gmail.com wrote:
2011/1/16 Andre Engels andreengels@gmail.com
As we're talking about commit access anyway - I _think_ I have commit access, but I have no idea where and how I can commit... Can anyone enlighten me?
But you have solved a problem I reported, do you remember? http://svn.wikimedia.org/viewvc/pywikipedia/trunk/pywikipedia/userinterfaces... Try to descend to alpha and remember, how did you do that. :-)
Well, with help from Valhallas I am a bit further now... I have SVN installed, and contacted the repository. The remaining issue at the moment is that I need a key (more precisely, a public/private key pair), and the one that I used to have was located on a hard disk that since then has crashed (and of which I of course had not made a back up). So if someone tells me where to send the new public key, I hopefully will be able to submit again.
... ;)
the opposite hold for me: I _know_ how to commit but I also _know_ that do not have access... ;)
this is why I had to start "my own branch": https://fisheye.toolserver.org/changelog/drtrigon and I would like to send improvements or new things upstream after testing them in my branch (and bot)... :)
Greetings
Am 16.01.2011 12:36, schrieb Andre Engels:
As we're talking about commit access anyway - I _think_ I have commit access, but I have no idea where and how I can commit... Can anyone enlighten me?
Then teach me, please. Is there a manual?
2011/1/16 Dr. Trigon dr.trigon@surfeu.ch
... ;)
the opposite hold for me: I _know_ how to commit but I also _know_ that do not have access... ;)
The ones mentioned earlier by Lewis [1] is not that bad in my oppinion. IF you understand german (sorry for that) you can start by reading [2] which helped me a lot in "the early days"... It is not complete but a good starter. You can find a lot about SVN in web, but as I feel the first few steps are a problem. IF you are using linux or other unix, I strongly recommend to install svn package, then you get the 'svn' command for your shell. Whit this you can use e.g. 'svn help' to get the first clue. SVN uses its own "language" YOU HAVE TO understand words like 'checkout', 'commit', 'diff', 'patch', 'merge', 'prop', ...
1. learn about 'svn checkout' or 'svn co' which simply creates a local copy to work with on your computer (later you can use 'svn update' but be careful since this does not overwrite changes you made, e.g. if you want to go back to the orignal version of a file you will have to delete if before updateing) 2. if you have changed something within that local copy you can use 'svn commit' or 'svn ci' to send that changes to the web/repository. 3. try to learn more about svn as you need it, e.g. I used SVN for about 6 months or more with these two commands only! more advanced things like 'propset' or else are important if you create your own SVN repo on the web from nothing - but if you are "just commiting patches" 1. and 2. should be all you need (more or less)
Hope this helps to get started.... somehow... ;)
There are pitfalls, but essentially nothing is lost in a SVN repo, everything can be undone if needed... So don't be afraid... :))
[1] http://www.mediawiki.org/wiki/Commit_access [2] http://kb.gnuher.de/zzz_old_articles/various/HOWTO%20-%20SVN%20Kurzanleitung...
Am 16.01.2011 13:24, schrieb Bináris:
Then teach me, please. Is there a manual?
2011/1/16 Dr. Trigon <dr.trigon@surfeu.ch mailto:dr.trigon@surfeu.ch>
... ;) the opposite hold for me: I _know_ how to commit but I also _know_ that do not have access... ;)-- Bináris
Pywikipedia-l mailing list Pywikipedia-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l
Thanks, Trigon. I understand German with a dictionary if necessary, ich habe das Abitur abgelegt, but 26 years ago... :-)
pywikipedia-l@lists.wikimedia.org