I dont know much about the history of these decisions, so just my own
thoughts...
On Wed, Jun 18, 2014 at 12:15 PM, Sorawee Porncharoenwase
<nullzero.free(a)gmail.com> wrote:
1) What is the preferable shebang? What I have seen
are:
- #!/usr/bin/python (such as scripts/add_text.py)
- #!/usr/bin/env python (such as scripts/archivebot.py)
- no shebang (such as scripts/catall.py)
I think '#!/usr/bin/env python' is the most versatile shebang. It
fails on systems which do not have env, but on systems with env in the
standard location, it allows the python executable to be anywhere.
2) Why some scripts (such as blockpageschecker.py) are
executable , while
the others (such as archivebot.py) are not?
IMO they should all be executable as they have a main block.
3) Why don't we always use async=True with all
scripts? I admit that I don't
know whether async has a negative impact, so I asked it here. Anyway, I
think that we can add async=True to touch.py, for example, without causing
any problem.
No idea. async does use different exception handling, and it probably
isnt properly covered by the unit tests.
4) Which one is preferable between "summary"
and "reason"? I think this
topic was previously discussed before, but I can't remember the final
resolution.
The codebase also uses 'comment', even in the config file.
https://gerrit.wikimedia.org/r/#/c/141392/
The API uses 'summary' and the webpage UI uses 'edit summary' - I
think 'summary' should be the preferred terminology.
--
John Vandenberg