Okay this might sound like a stupid question, but how can we test it?
And just for clarification, when someone uploads a patch, not the e-mail in the git commit are important but the account which you used to push it to the repository? Couldn't you automatically generate a list automatically from the admins (or +2able contributors?) of the project? And why is it okay to run the test on a CR+1 vote (which is afaik everyone with an account) but not on push?
2015-01-15 11:44 GMT+01:00 Antoine Musso hashar+wmf@free.fr:
Hello,
Yesterday I have restricted the tox Jenkins jobs to only be run by whitelisted person. That is rather inconvenient :-(
To whitelist a person, its Gerrit email address would have to be added to integration/config.git zuul/layout.yaml in a list and in a huge regex.
I have a patch pending that I have yet to test, which would cause test to run when a whitelisted person votes CR+1 and the patch hasn't been tested yet. That would help a lot. The patch is:
https://gerrit.wikimedia.org/r/#/c/184886/
I have no idea when I will get to polish it up and deploy it though :(
-- Antoine "hashar" Musso
Pywikipedia-l mailing list Pywikipedia-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l