And just for clarification, when someone uploads a patch, not the e-mail in the git commit are important but the account which you used to push it to the repository?

Couldn't you automatically generate a list automatically from the admins (or +2able contributors?) of the project?

afaik everyone with an account) but not on push?

But according to https://gerrit.wikimedia.org/r/184967 it shouldn't trigger them. And okay didn't saw that only trusted accounts would be considered for +1. And is there no way to have some tests executed even from not trusted accounts or is that security wise impossible? 2015-01-15 13:33 GMT+01:00 Merlijn van Deen <valhallasw(a)arctus.nl>nl>: > On 15 January 2015 at 13:02, Fabian Neundorf <CommodoreFabianus(a)gmx.de> > wrote: >> And just for clarification, when someone uploads a patch, not the >> e-mail in the git commit are important but the account which you used >> to push it to the repository? > > Yes, the account used to submit the Gerrit changeset. > >> Couldn't you automatically generate a >> list automatically from the admins (or +2able contributors?) of the >> project? > >> And why is it okay to run the test on a CR+1 vote (which is >> afaik everyone with an account) but not on push? > > > The test are triggered on a +1 from /whitelisted accounts/. > > The list of whitelisted accounts is here: > https://github.com/wikimedia/integration-config/blob/master/zuul/layout.yam… > > > As a workaround, posting 'recheck' should also trigger the tests. Antoine, > maybe it's an idea to also trigger on comments that start with 'check' > (instead of 'only contain recheck')? That might be easier to implement than > your +1 solution. > > Merlijn > > _______________________________________________ > Pywikipedia-l mailing list > Pywikipedia-l(a)lists.wikimedia.org > https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l >

On 01/15/2015 10:42 AM, Fabian Neundorf wrote: +2 will still trigger the submit jobs, regardless of whether you are whitelisted or not. I submitted[1] to add you to the whitelist. We should also make sure that all of the other people with +2 in Pywikibot are whitelisted. [1] https://gerrit.wikimedia.org/r/185219 -- Legoktm _______________________________________________ Pywikipedia-l mailing list Pywikipedia-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l

On 15 January 2015 at 21:42, Ricordisamoa &lt;ricordisamoa(a)openmailbox.org <mailto:ricordisamoa@openmailbox.org>> wrote: This may sound stupid, but... why can't jobs be run by patch submitters? Because they would effectively get full (user-level) access on the unit test servers. It's basically a check to prevent non-trusted users (after all, registration is completely open) from running potentially malicious code. People on the 'OK' list are expected to not submit malicious code to begin with ;-) Merlijn