VcamX added a comment.
@jayvdb This is the travis ci test report https://travis-ci.org/VcamX/pywikibot-core/builds/63499094. I reviewed the patch and also tried to follow its idea but found it break some internal things. So I made the patch myself. I checkouted a new branch https://github.com/VcamX/pywikibot-core/tree/requests based on the commit https://github.com/wikimedia/pywikibot-core/commit/ddb553f267d3af3fa5eedda00103a70b79f7fa75 from master branch, which showed itself pass the test https://travis-ci.org/wikimedia/pywikibot-core/builds/63069436 on travis ci.
Test 7 https://travis-ci.org/VcamX/pywikibot-core/jobs/63499106 and 8 https://travis-ci.org/VcamX/pywikibot-core/jobs/63499111 failed because requests introduced some warning to stderr, which cause some `assertIsNone(stderr_other)` failed. So I think we could ignore this assertion error.
Test 12 https://travis-ci.org/VcamX/pywikibot-core/jobs/63499123 failed because `AssertionError: LockedPage not raised by save`. I think this test is for non-sysop account. But pywikibot doesn't figure out my account is sysop, so not to skip this test, which cause saving a locked page succeed.
I almost replaced httplib2 with requests. And I removed some tests for httplib2, also modified some test case to fit with requests lib. You could check those modification. Sorry about those small and messy commits. I could squash them If you want :)
TASK DETAIL https://phabricator.wikimedia.org/T98671
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: VcamX Cc: Ricordisamoa, Aklapper, jayvdb, pywikipedia-bugs