jayvdb added a blocking task: T98439: Add support for using python-requests. TASK DETAIL https://phabricator.wikimedia.org/T98671 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: VcamX, jayvdb Cc: Aklapper, jayvdb, pywikipedia-bugs

VcamX added a comment. @jayvdb This is the travis ci test report <https://travis-ci.org/VcamX/pywikibot-core/builds/63499094>. I reviewed the patch and also tried to follow its idea but found it break some internal things. So I made the patch myself. I checkouted a new branch <https://github.com/VcamX/pywikibot-core/tree/requests> based on the commit <https://github.com/wikimedia/pywikibot-core/commit/ddb553f267d3af3fa5eedda00103a70b79f7fa75> from master branch, which showed itself pass the test <https://travis-ci.org/wikimedia/pywikibot-core/builds/63069436> on travis ci. Test 7 <https://travis-ci.org/VcamX/pywikibot-core/jobs/63499106> and 8 <https://travis-ci.org/VcamX/pywikibot-core/jobs/63499111> failed because requests introduced some warning to stderr, which cause some `assertIsNone(stderr_other)` failed. So I think we could ignore this assertion error. Test 12 <https://travis-ci.org/VcamX/pywikibot-core/jobs/63499123> failed because `AssertionError: LockedPage not raised by save`. I think this test is for non-sysop account. But pywikibot doesn't figure out my account is sysop, so not to skip this test, which cause saving a locked page succeed. I almost replaced httplib2 with requests. And I removed some tests for httplib2, also modified some test case to fit with requests lib. You could check those modification. Sorry about those small and messy commits. I could squash them If you want :) TASK DETAIL https://phabricator.wikimedia.org/T98671 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: VcamX Cc: Ricordisamoa, Aklapper, jayvdb, pywikipedia-bugs

jayvdb added a comment. In https://phabricator.wikimedia.org/T98671#1301633, @VcamX wrote: I agree this assertion is very likely to not be a significant problem, however we need the tests to pass. ;-) It looks like this is a problem only with the Python 2.6 builds, so any solution should use 'if sys.version_info < (2, 7):' so the 'solution' doesnt affect more modern python versions which dont need fixing. There are three possible options that I can see quickly, which may or may not work: 1. call urllib3.disable_warnings() somewhere to prevent this warning 2. try to fix the security problem described by this warning, e.g. by installing root certificates - https://urllib3.readthedocs.org/en/latest/security.html#certifi-with-urllib3 3. silence this specific warning only. I believe it is being captured by the logging layer, and is being routed through pywikibot/userinterfaces/terminal_interface_base.py TerminalHandler.emit , so you may be able to detect and suppress this warning in there. TASK DETAIL https://phabricator.wikimedia.org/T98671 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: VcamX, jayvdb Cc: XZise, Ricordisamoa, Aklapper, jayvdb, pywikipedia-bugs

jayvdb added a comment. In your setup.py, you require 'requests >=2, <3' , but pwb.py reports 'Python module requests >= 2.7.0 is required.' Does requests pre 2.7 not include `__version__`? TASK DETAIL https://phabricator.wikimedia.org/T98671 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: VcamX, jayvdb Cc: XZise, Ricordisamoa, Aklapper, jayvdb, pywikipedia-bugs

VcamX added a comment. @jayvdb The latest version passed the test <https://travis-ci.org/VcamX/pywikibot-core/builds/63634821>. With the help of @XZise, I also sent a patch <https://gerrit.wikimedia.org/r/#/c/212776/> to improve test_protected of TestSaveFailure in tests/edit_failure_tests.py TASK DETAIL https://phabricator.wikimedia.org/T98671 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: VcamX Cc: XZise, Ricordisamoa, Aklapper, jayvdb, pywikipedia-bugs

gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 213977 had a related patch set uploaded (by VcamX): Switch from httplib2 to requests https://gerrit.wikimedia.org/r/213977 TASK DETAIL https://phabricator.wikimedia.org/T98671 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: VcamX, gerritbot Cc: gerritbot, XZise, Ricordisamoa, Aklapper, jayvdb, pywikipedia-bugs

VcamX added a comment. @jayvdb The patch is on Gerrit <https://gerrit.wikimedia.org/r/#/c/213977/> now. The `async_request` seems a little hard to test.. TASK DETAIL https://phabricator.wikimedia.org/T98671 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: VcamX Cc: gerritbot, XZise, Ricordisamoa, Aklapper, jayvdb, pywikipedia-bugs

gerritbot added a comment. Change 213977 merged by jenkins-bot: Switch from httplib2 to requests https://gerrit.wikimedia.org/r/213977 TASK DETAIL https://phabricator.wikimedia.org/T98671 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: VcamX, gerritbot Cc: gerritbot, XZise, Ricordisamoa, Aklapper, jayvdb, pywikipedia-bugs

jayvdb closed blocking task T98439: Add support for using python-requests as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T98671 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: VcamX, jayvdb Cc: gerritbot, XZise, Ricordisamoa, Aklapper, jayvdb, pywikipedia-bugs