Patches item #3522917, was opened at 2012-05-01 22:23
Message generated for change (Comment added) made by valhallasw
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603140&aid=352291…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Jenith (yjenith)
Assigned to: Nobody/Anonymous (nobody)
Summary: Picasa copier upload script
Initial Comment:
A tool to do batch uploading of Google web album (Picasa) to Commons using Pywikipedia and
Google data API.
----------------------------------------------------------------------
Comment By: Merlijn S. van Deen (valhallasw)
Date: 2012-05-02 13:11
Message:
Overall, I like your code very much. I have two comments:
- You mix tabs and spaces for indentation. Please use spaces exclusively
- There are a lot of commented-out code blocks. Please either remove them
or implement them
On xqt's question on the dependencies:
- PIL is only required if the Tk interface is used -> please move the
import to the functions where it is required, so that the bot can also be
used without it
- I think we should remove all dependencies (such as simplejson, but also
some http library in the rewrite) and switch to a virtualenv / pip based
system. I'm not sure how well that would work on windows, though...
----------------------------------------------------------------------
Comment By: xqt (xqt)
Date: 2012-05-01 23:11
Message:
Thanks for your source.
Hm, gdata and pil aren't part of the pwb package (yet). Where could the bot
owner get them?
You should use the pywikibot.showHelp() method to display the
documtentation. List and docufy all given options.
If the usage/Help is shown the additional outputs about uploads should be
omitted.
Greetings
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603140&aid=352291…