Bugs item #2986051, was opened at 2010-04-12 14:33
Message generated for change (Settings changed) made by djbarrett
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2986051&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Open
Resolution: Rejected
Priority: 5
Private: No
Submitted By: Daniel Barrett (djbarrett)
Assigned to: xqt (xqt)
Summary: weblinkchecker should ignore URLs inside some tags, part 2
Initial Comment:
This is a followup to [pywikipediabot-Bugs-1969051] \"weblinkchecker should ignore URLs inside some tags\"
The fix in pyrev:8076 by xqt is appreciated, but not an appropriate solution. The particular tag I listed in the ticket, \"<sql>\", was just an example. The fix by xqt simply hard-coded this example (bogus) tag into the Pywikipedia source code:
svn diff -c8076 http://svn.wikimedia.org/svnroot/pywikipedia/trunk/pywikipedia
A better fix would be to recognize when you are reading a tag attribute:
<AnyTagGoesHere ... attr=\'http://whatever\' ...>
{{AnyTemplateOrParserFunction | attr=http://whatever
and ignore the URL in these situations.
$ python version.py
Pywikipedia [http] trunk/pywikipedia (r8050, 2010/04/01, 15:43:14)
Python 2.4.3 (#1, Sep 3 2009, 15:37:37)
[GCC 4.1.2 20080704 (Red Hat 4.1.2-46)]
----------------------------------------------------------------------
>Comment By: Daniel Barrett (djbarrett)
Date: 2010-04-12 15:39
Message:
I see your point. Three notes:
1. Can this be an OPTION for weblinkchecker?
2. If not, can you at least strip off the trailing single quotes (shown in
bug 1969051) so you don't get broken URLs? Since single quotes are valid
in tags but should not be part of the URL.
3. In any case, you should revert pyrev:8076 because there is no such tag
as <sql>.
----------------------------------------------------------------------
Comment By: xqt (xqt)
Date: 2010-04-12 15:26
Message:
I do not agree. Since it is legal putting URLs into <ref /> tags as well as
others like <noinclude> etc. or assigning URLs to a template field, this
normally shouldn't be ignored by the weblinkchecker but checked if this URL
is still valid.
----------------------------------------------------------------------
Comment By: Merlijn S. van Deen (valhallasw)
Date: 2010-04-12 15:23
Message:
I disagree. It is very well possible to have a sensible URL in a template
(e.g. a reference). I'd suggest to only add 'exceptions', as has been done
in r8076.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2986051&group_…
Bugs item #2986051, was opened at 2010-04-12 20:33
Message generated for change (Settings changed) made by xqt
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2986051&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Pending
Resolution: Rejected
Priority: 5
Private: No
Submitted By: Daniel Barrett (djbarrett)
>Assigned to: xqt (xqt)
Summary: weblinkchecker should ignore URLs inside some tags, part 2
Initial Comment:
This is a followup to [pywikipediabot-Bugs-1969051] \"weblinkchecker should ignore URLs inside some tags\"
The fix in pyrev:8076 by xqt is appreciated, but not an appropriate solution. The particular tag I listed in the ticket, \"<sql>\", was just an example. The fix by xqt simply hard-coded this example (bogus) tag into the Pywikipedia source code:
svn diff -c8076 http://svn.wikimedia.org/svnroot/pywikipedia/trunk/pywikipedia
A better fix would be to recognize when you are reading a tag attribute:
<AnyTagGoesHere ... attr=\'http://whatever\' ...>
{{AnyTemplateOrParserFunction | attr=http://whatever
and ignore the URL in these situations.
$ python version.py
Pywikipedia [http] trunk/pywikipedia (r8050, 2010/04/01, 15:43:14)
Python 2.4.3 (#1, Sep 3 2009, 15:37:37)
[GCC 4.1.2 20080704 (Red Hat 4.1.2-46)]
----------------------------------------------------------------------
Comment By: xqt (xqt)
Date: 2010-04-12 21:26
Message:
I do not agree. Since it is legal putting URLs into <ref /> tags as well as
others like <noinclude> etc. or assigning URLs to a template field, this
normally shouldn't be ignored by the weblinkchecker but checked if this URL
is still valid.
----------------------------------------------------------------------
Comment By: Merlijn S. van Deen (valhallasw)
Date: 2010-04-12 21:23
Message:
I disagree. It is very well possible to have a sensible URL in a template
(e.g. a reference). I'd suggest to only add 'exceptions', as has been done
in r8076.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2986051&group_…
Bugs item #2986051, was opened at 2010-04-12 20:33
Message generated for change (Comment added) made by xqt
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2986051&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
>Resolution: Rejected
Priority: 5
Private: No
Submitted By: Daniel Barrett (djbarrett)
Assigned to: Nobody/Anonymous (nobody)
Summary: weblinkchecker should ignore URLs inside some tags, part 2
Initial Comment:
This is a followup to [pywikipediabot-Bugs-1969051] \"weblinkchecker should ignore URLs inside some tags\"
The fix in pyrev:8076 by xqt is appreciated, but not an appropriate solution. The particular tag I listed in the ticket, \"<sql>\", was just an example. The fix by xqt simply hard-coded this example (bogus) tag into the Pywikipedia source code:
svn diff -c8076 http://svn.wikimedia.org/svnroot/pywikipedia/trunk/pywikipedia
A better fix would be to recognize when you are reading a tag attribute:
<AnyTagGoesHere ... attr=\'http://whatever\' ...>
{{AnyTemplateOrParserFunction | attr=http://whatever
and ignore the URL in these situations.
$ python version.py
Pywikipedia [http] trunk/pywikipedia (r8050, 2010/04/01, 15:43:14)
Python 2.4.3 (#1, Sep 3 2009, 15:37:37)
[GCC 4.1.2 20080704 (Red Hat 4.1.2-46)]
----------------------------------------------------------------------
>Comment By: xqt (xqt)
Date: 2010-04-12 21:26
Message:
I do not agree. Since it is legal putting URLs into <ref /> tags as well as
others like <noinclude> etc. or assigning URLs to a template field, this
normally shouldn't be ignored by the weblinkchecker but checked if this URL
is still valid.
----------------------------------------------------------------------
Comment By: Merlijn S. van Deen (valhallasw)
Date: 2010-04-12 21:23
Message:
I disagree. It is very well possible to have a sensible URL in a template
(e.g. a reference). I'd suggest to only add 'exceptions', as has been done
in r8076.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2986051&group_…
Bugs item #2986051, was opened at 2010-04-12 20:33
Message generated for change (Comment added) made by valhallasw
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2986051&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Daniel Barrett (djbarrett)
Assigned to: Nobody/Anonymous (nobody)
Summary: weblinkchecker should ignore URLs inside some tags, part 2
Initial Comment:
This is a followup to [pywikipediabot-Bugs-1969051] \"weblinkchecker should ignore URLs inside some tags\"
The fix in pyrev:8076 by xqt is appreciated, but not an appropriate solution. The particular tag I listed in the ticket, \"<sql>\", was just an example. The fix by xqt simply hard-coded this example (bogus) tag into the Pywikipedia source code:
svn diff -c8076 http://svn.wikimedia.org/svnroot/pywikipedia/trunk/pywikipedia
A better fix would be to recognize when you are reading a tag attribute:
<AnyTagGoesHere ... attr=\'http://whatever\' ...>
{{AnyTemplateOrParserFunction | attr=http://whatever
and ignore the URL in these situations.
$ python version.py
Pywikipedia [http] trunk/pywikipedia (r8050, 2010/04/01, 15:43:14)
Python 2.4.3 (#1, Sep 3 2009, 15:37:37)
[GCC 4.1.2 20080704 (Red Hat 4.1.2-46)]
----------------------------------------------------------------------
>Comment By: Merlijn S. van Deen (valhallasw)
Date: 2010-04-12 21:23
Message:
I disagree. It is very well possible to have a sensible URL in a template
(e.g. a reference). I'd suggest to only add 'exceptions', as has been done
in r8076.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2986051&group_…
Bugs item #2986051, was opened at 2010-04-12 14:33
Message generated for change (Tracker Item Submitted) made by djbarrett
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2986051&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Daniel Barrett (djbarrett)
Assigned to: Nobody/Anonymous (nobody)
Summary: weblinkchecker should ignore URLs inside some tags, part 2
Initial Comment:
This is a followup to [pywikipediabot-Bugs-1969051] \"weblinkchecker should ignore URLs inside some tags\"
The fix in pyrev:8076 by xqt is appreciated, but not an appropriate solution. The particular tag I listed in the ticket, \"<sql>\", was just an example. The fix by xqt simply hard-coded this example (bogus) tag into the Pywikipedia source code:
svn diff -c8076 http://svn.wikimedia.org/svnroot/pywikipedia/trunk/pywikipedia
A better fix would be to recognize when you are reading a tag attribute:
<AnyTagGoesHere ... attr=\'http://whatever\' ...>
{{AnyTemplateOrParserFunction | attr=http://whatever
and ignore the URL in these situations.
$ python version.py
Pywikipedia [http] trunk/pywikipedia (r8050, 2010/04/01, 15:43:14)
Python 2.4.3 (#1, Sep 3 2009, 15:37:37)
[GCC 4.1.2 20080704 (Red Hat 4.1.2-46)]
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2986051&group_…
Bugs item #2985959, was opened at 2010-04-12 22:57
Message generated for change (Tracker Item Submitted) made by wikishizhao
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2985959&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: shizhao (wikishizhao)
Assigned to: Nobody/Anonymous (nobody)
Summary: IsRedirectPage error
Initial Comment:
if nontalkpage.isEmpty():
File "/home/shizhao2/talk/wikipedia.py", line 1025, in isEmpty
txt = self.get()
File "/home/shizhao2/talk/wikipedia.py", line 609, in get
raise IsRedirectPage, self._redirarg
pywikibot.exceptions.IsRedirectPage: Template:Canon DSLR cameras
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2985959&group_…
Patches item #2985564, was opened at 2010-04-11 21:44
Message generated for change (Comment added) made by xqt
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603140&aid=2985564&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: Postponed
Priority: 5
Private: No
Submitted By: masti (masti01)
Assigned to: xqt (xqt)
Summary: cosmetic_changes.py
Initial Comment:
if the link and description are the same except for capitalisation use link as link skipping description. Useful for cleaning up after capitalisation related redirects cleaning. Example: http://pl.wikipedia.org/w/index.php?diff=21129378&oldid=21129374&rcid=21691…
----------------------------------------------------------------------
>Comment By: xqt (xqt)
Date: 2010-04-12 16:20
Message:
Wouldn't it be a better way to fix that behavior in the main script? For
example: I use a modificated solve_disambiguation.py which always uses the
page link without the description for disambig pages which is recommended
in de-wiki. Put it could cause problems with articles. The point is: you
could not have any influence to cc but you may have it on fixing_redirects
or solve_disambiguation as an option if using it in non-autonomous mode.
And I coundn't say that this sort of spelling-correction alway works well.
----------------------------------------------------------------------
Comment By: masti (masti01)
Date: 2010-04-12 15:39
Message:
I use that in case we are moving pages due to the fact of misspelling or
wrong capitalisation of article title. Then when fixing_redirects or using
solve_disambiguation we have a proper link but the description stays wrong.
----------------------------------------------------------------------
Comment By: xqt (xqt)
Date: 2010-04-12 13:12
Message:
I am not sure whether this is a good idea of cause this does spelling
changes overruling human edits. If running this in autonomous mode we must
enshure the result is always right. That's why I would like to wait for
other comments.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603140&aid=2985564&group_…
Patches item #2985564, was opened at 2010-04-11 21:44
Message generated for change (Comment added) made by masti01
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603140&aid=2985564&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: Postponed
Priority: 5
Private: No
Submitted By: masti (masti01)
Assigned to: xqt (xqt)
Summary: cosmetic_changes.py
Initial Comment:
if the link and description are the same except for capitalisation use link as link skipping description. Useful for cleaning up after capitalisation related redirects cleaning. Example: http://pl.wikipedia.org/w/index.php?diff=21129378&oldid=21129374&rcid=21691…
----------------------------------------------------------------------
Comment By: masti (masti01)
Date: 2010-04-12 15:39
Message:
I use that in case we are moving pages due to the fact of misspelling or
wrong capitalisation of article title. Then when fixing_redirects or using
solve_disambiguation we have a proper link but the description stays wrong.
----------------------------------------------------------------------
Comment By: xqt (xqt)
Date: 2010-04-12 13:12
Message:
I am not sure whether this is a good idea of cause this does spelling
changes overruling human edits. If running this in autonomous mode we must
enshure the result is always right. That's why I would like to wait for
other comments.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603140&aid=2985564&group_…