Bugs item #2986051, was opened at 2010-04-12 20:33
Message generated for change (Settings changed) made by xqt
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=298605…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Pending
Resolution: Rejected
Priority: 5
Private: No
Submitted By: Daniel Barrett (djbarrett)
Assigned to: xqt (xqt)
Summary: weblinkchecker
should ignore URLs inside some tags, part 2
Initial Comment:
This is a followup to [pywikipediabot-Bugs-1969051] \"weblinkchecker should ignore
URLs inside some tags\"
The fix in pyrev:8076 by xqt is appreciated, but not an appropriate solution. The
particular tag I listed in the ticket, \"<sql>\", was just an example. The
fix by xqt simply hard-coded this example (bogus) tag into the Pywikipedia source code:
svn diff -c8076
http://svn.wikimedia.org/svnroot/pywikipedia/trunk/pywikipedia
A better fix would be to recognize when you are reading a tag attribute:
<AnyTagGoesHere ... attr=\'http://whatever\' ...>
{{AnyTemplateOrParserFunction | attr=http://whatever
and ignore the URL in these situations.
$ python version.py
Pywikipedia [http] trunk/pywikipedia (r8050, 2010/04/01, 15:43:14)
Python 2.4.3 (#1, Sep 3 2009, 15:37:37)
[GCC 4.1.2 20080704 (Red Hat 4.1.2-46)]
----------------------------------------------------------------------
Comment By: xqt (xqt)
Date: 2010-04-12 21:26
Message:
I do not agree. Since it is legal putting URLs into <ref /> tags as well as
others like <noinclude> etc. or assigning URLs to a template field, this
normally shouldn't be ignored by the weblinkchecker but checked if this URL
is still valid.
----------------------------------------------------------------------
Comment By: Merlijn S. van Deen (valhallasw)
Date: 2010-04-12 21:23
Message:
I disagree. It is very well possible to have a sensible URL in a template
(e.g. a reference). I'd suggest to only add 'exceptions', as has been done
in r8076.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=298605…