Thanks Tom for all the information on the upcoming changes for version 2.0.0 and I think I should have already used the unreleased 2.x branch version. I will be happy to have it around in production.
So far I only used 1.x which does not really play with Chrome while 2.x is equally good in Firefox and Chrome.
The most troubling thing however is that I more or less heavily adapted the CSS of the sites using foreground and the breakage here is pretty massive (beyond recognition - I thought I was accessing a different website which is having many worries). I had to delete practically all adaptions and start over again. In comparison the tabs appear to be of no concern.
I think checks like the ones Mark is proposing should focus on changes in configuration parameters and their settings. Everything on the wiki itself appears hard to pick to me. Here we should rely on some kind of quality documentation and migration guides.
Cheers Karsten
Am 18.04.2017 um 04:00 schrieb Tom Hutchison:
Hi Mark
Sounds like a great idea but the changes wouldn't have a method to check for tabs. Anyone could use tabs anywhere on any page without limitations.
Foundation 4 used <section> tags with classes to build the tabs.[0] Foundation 5 (v2.0's build) uses a combination of <ul>, <li> and <a href=""> to make tabs. [1] <ul> and <li> aren't an issue. It is the <a> tags which are sanitized. For v2.0, when the tabs feature is enabled the sanitizer used to strip out <a> tags is reversed and the output makes the <a> tag active again.
Because of the change an admin would have to go to any page they are using tabs on and update the wiki markup to use <ul>, <li> and <a> tags. Disappointed in the way Zurb changed this from 4. At least they did keep the same code valid from Foundation 5 to Foundation 6. Unfortunately, this doesn't help us.
Tom
[0] http://foundation.zurb.com/sites/docs/v/4.3.2/components/section.html [1] http://foundation.zurb.com/sites/docs/v/5.5.3/components/tabs.html
-----Original Message----- From: Foreground [mailto:foreground-bounces@lists.wikimedia.org] On Behalf Of Mark A. Hershberger Sent: Monday, April 17, 2017 11:05 AM To: Discussion about the Mediawiki skin Foreground (https://www.mediawiki.org/wiki/Skin:Foreground) <foreground@lists.wikimedia.org> Subject: Re: [Foreground] Foreground 2.0.0?
I've been watching how upgrades are handled in the MediaWiki world for a few years and I think we can all do better than we have been.
While going to 2.0 is a big help, could we put in a hook and ask people upgrading to run update.php?
In the hook, we could check for the use of tabs and make sure that it is compatible with Foreground 2.0.
Alternatively, we could set check to see (via a flag in the DB?) if this is the first time the 2.0 version has been run and show a notice (to admins only?) of changes that need to be made.
I haven't yet looked at the differences, so I'm not sure how feasible this is, but it would help
I'm not tied to any of these ideas, of course. I just want to make the use of the software better for the end user.
Thanks,
Mark.
Mark A. Hershberger NicheWork LLC 717-271-1084
Foreground mailing list Foreground@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/foreground