[Apologies for cross-posting]
Hi,
TL;DR: We will take our Gerrit instance at gerrit.wikimeda.org offline on Saturday, 27th of June from 17:00--22:00 UTC (hopefully much shorter) to upgrade to the latest Gerrit v3.2.2.
(10:00--15:00 San Francisco time, and 19:00--24:00 Central European time)
---------------------------------
We're currently running Gerrit v2.15, which is no longer supported and we will upgrade to Gerrit v3.2 on Saturday 27th of June. This new version brings lots of improvements. The most noticeable change is probably the UI overhaul. The (default) "old UI" gets removed and the "new UI" has been completely revamped. It's much more modern looking and easier to use. And it also became far more usable on mobile phones. But the new version of course also comes with fixes and additions around the ssh interface, and the HTTP API.
Since this is such a big upgrade, we want to give you a chance to look at it beforehand. You can test at
https://gerrit-test.wikimedia.org/
It holds a copy of our Gerrit data as of 15th of June, and it runs the new Gerrit v3.2.2. We'll keep tuning things there during this week, so it might get an occasional restart. But look around and test the new UI, the HTTP API, etc.
If you run into issues or discover bugs, please open tickets in Phabricator and set the Gerrit 3.x upgrade task (T254158) as parent.
Note that this test Gerrit instance is already hooked up with our Phabricator. If you upload / merge / abandon / etc changes with a `Bug: Tnnnn` footer, you'll get comments on the corresponding tasks in Gerrit. So please use our test task T775 for your experiments.
As everything, also this upgrade comes with a few downsides:
* The new UI no longer works on Internet Explorer (currently ~0.02% of Gerrit's web requests). Microsoft's Edge browser works though. So if you are still using Internet Explorer, please consider switching to a different browser.
* Users of git-review need to use at least version 1.27 (released September 2018). Otherwise uploading changes will fail.
* Your git should be at least version 2.2.0 (released November 2014) to take advantage of the new, much simpler commit-msg hook.
Keeping my fingers crossed for a painless update, Christian with lots of helping hands from RelEng, and SRE
Hello everyone, for me new Gerrit looks great.
But, I don't know why I can't edit files via UI as in (soon old) Gerrit. In documentation ( https://gerrit-review.googlesource.com/Documentation/user-inline-edit.html, section Adding a File to a Change) is how-to. But I can't see these options on https://gerrit-test.wikimedia.org/r/c/sandbox/+/605706).
How I can add/remove/edit files via UI?
Best regards, Zoran Dori volunteer, Wikimedia Serbia s: kizule.xyz e: zorandori4444@gmail.com
*Imagine a world in which every single human being can freely share inthe sum of all knowledge.*
Hi Zoran,
On Sun, Jun 21, 2020 at 09:10:03AM +0200, Zoran Dori wrote:
But, I don't know why I can't edit files via UI as in (soon old) Gerrit
Thanks for bringing that up.
The needed `codemirror-editor` plugin was not yet loaded, which I now did.
Editing through the UI now works for me.
Could you please try again if it works for you now too?
Have fun, Christian
Hi Christian, thanks for responding! Editing now works, it is great also!
Best regards, Zoran Dori volunteer, Wikimedia Serbia s: kizule.xyz e: zorandori4444@gmail.com
*Imagine a world in which every single human being can freely share inthe sum of all knowledge.*
the code mirror plugin isn't really needed to edit, since pg falls back to the default editor. On Sunday, 21 June 2020, 15:21:31 BST, Zoran Dori zorandori4444@gmail.com wrote:
Hi Christian,thanks for responding! Editing now works, it is great also! Best regards,
| | Zoran Dorivolunteer, Wikimedia Serbias: kizule.xyz e: zorandori4444@gmail.com |
Imagine a world in which every single human being can freely share in the sum of all knowledge._______________________________________________ Wikimedia Cloud Services mailing list Cloud@lists.wikimedia.org (formerly labs-l@lists.wikimedia.org) https://lists.wikimedia.org/mailman/listinfo/cloud
Hi,
On Sun, Jun 21, 2020 at 02:46:48PM +0000, Paladox via Cloud wrote:
the code mirror plugin isn't really needed to edit, since pg falls back to the default editor.
While you're right that the default editor is there, it is severely lacking [1] and it's far worse than what our current old Gerrit v2.15 offered in the GWT part.
The `codemirror-editor` plugin typically comes bundled with Gerrit, is trivially small and it was my list to set it up for the test Gerrit.
Regardless of whether we call the default editor fit for file-editing or not, can we agree that the codemirror-editor is so much better that it's worth to have this simple plugin? ;-)
Have fun, Christian
[1] Even the Googlers don't want it [2]:
I think that, for now, the minimum requirement for me to be happy setting the editing experience live is a functional CodeMirror editor with working syntax highlighting. As of right now, the editor built into PolyGerrit is mostly just for debugging -- it doesn't properly capture tabs [...]
And since that quote is from 2017, I retried and it still cannot even do tabs properly. That's a no go.
[2] https://bugs.chromium.org/p/gerrit/issues/detail?id=4437
Oh, yes! I would prefer the codemirror plugin, just that you can edit without it :) On Sunday, 21 June 2020, 20:03:45 BST, Christian Aistleitner christian@quelltextlich.at wrote:
Hi,
On Sun, Jun 21, 2020 at 02:46:48PM +0000, Paladox via Cloud wrote:
the code mirror plugin isn't really needed to edit, since pg falls back to the default editor.
While you're right that the default editor is there, it is severely lacking [1] and it's far worse than what our current old Gerrit v2.15 offered in the GWT part.
The `codemirror-editor` plugin typically comes bundled with Gerrit, is trivially small and it was my list to set it up for the test Gerrit.
Regardless of whether we call the default editor fit for file-editing or not, can we agree that the codemirror-editor is so much better that it's worth to have this simple plugin? ;-)
Have fun, Christian
[1] Even the Googlers don't want it [2]:
I think that, for now, the minimum requirement for me to be happy setting the editing experience live is a functional CodeMirror editor with working syntax highlighting. As of right now, the editor built into PolyGerrit is mostly just for debugging -- it doesn't properly capture tabs [...]
And since that quote is from 2017, I retried and it still cannot even do tabs properly. That's a no go.
[2] https://bugs.chromium.org/p/gerrit/issues/detail?id=4437
Hi,
just a heads up that the Gerrit upgrade (see below) will begin in about an hour. (If you want to read along, coordination will happen in IRC in #wikimedia-operations)
Have fun, Christian
On Sat, Jun 20, 2020 at 11:58:23PM +0200, Christian Aistleitner via Wikitech-l wrote:
[Apologies for cross-posting]
Hi,
TL;DR: We will take our Gerrit instance at gerrit.wikimeda.org offline on Saturday, 27th of June from 17:00--22:00 UTC (hopefully much shorter) to upgrade to the latest Gerrit v3.2.2.
(10:00--15:00 San Francisco time, and 19:00--24:00 Central European time)
We're currently running Gerrit v2.15, which is no longer supported and we will upgrade to Gerrit v3.2 on Saturday 27th of June. This new version brings lots of improvements. The most noticeable change is probably the UI overhaul. The (default) "old UI" gets removed and the "new UI" has been completely revamped. It's much more modern looking and easier to use. And it also became far more usable on mobile phones. But the new version of course also comes with fixes and additions around the ssh interface, and the HTTP API.
Since this is such a big upgrade, we want to give you a chance to look at it beforehand. You can test at
https://gerrit-test.wikimedia.org/
It holds a copy of our Gerrit data as of 15th of June, and it runs the new Gerrit v3.2.2. We'll keep tuning things there during this week, so it might get an occasional restart. But look around and test the new UI, the HTTP API, etc.
If you run into issues or discover bugs, please open tickets in Phabricator and set the Gerrit 3.x upgrade task (T254158) as parent.
Note that this test Gerrit instance is already hooked up with our Phabricator. If you upload / merge / abandon / etc changes with a `Bug: Tnnnn` footer, you'll get comments on the corresponding tasks in Gerrit. So please use our test task T775 for your experiments.
As everything, also this upgrade comes with a few downsides:
- The new UI no longer works on Internet Explorer (currently ~0.02% of
Gerrit's web requests). Microsoft's Edge browser works though. So if you are still using Internet Explorer, please consider switching to a different browser.
- Users of git-review need to use at least version 1.27 (released
September 2018). Otherwise uploading changes will fail.
- Your git should be at least version 2.2.0 (released November 2014)
to take advantage of the new, much simpler commit-msg hook.
Keeping my fingers crossed for a painless update, Christian with lots of helping hands from RelEng, and SRE
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Hi,
The Gerrit upgrade finished, and the new and shiny Gerrit v3.2.2 is live now on gerrit.wikimedia.org and is good to use again.
Please test and if you run into issues, don't hesitate to file a ticket in Phabricator (Bonus points for adding the 'Gerrit' project and/or making T254158 a parent task)
Huge thanks to all the people who helped. Foremost mutante and paladox who both spent countless hours to prepare the upgrade. Also hashar whose help around CI and deployment was invaluable. And all the other hands who helped in preparing and deploying: thcipriani, jynus, marostegui, godog and all whom I've forgotten. This was a huge team effort. Thanks all!
Have fun, Christian
On Sat, Jun 20, 2020 at 11:58:23PM +0200, Christian Aistleitner via Wikitech-l wrote:
[Apologies for cross-posting]
Hi,
TL;DR: We will take our Gerrit instance at gerrit.wikimeda.org offline on Saturday, 27th of June from 17:00--22:00 UTC (hopefully much shorter) to upgrade to the latest Gerrit v3.2.2.
(10:00--15:00 San Francisco time, and 19:00--24:00 Central European time)
We're currently running Gerrit v2.15, which is no longer supported and we will upgrade to Gerrit v3.2 on Saturday 27th of June. This new version brings lots of improvements. The most noticeable change is probably the UI overhaul. The (default) "old UI" gets removed and the "new UI" has been completely revamped. It's much more modern looking and easier to use. And it also became far more usable on mobile phones. But the new version of course also comes with fixes and additions around the ssh interface, and the HTTP API.
Since this is such a big upgrade, we want to give you a chance to look at it beforehand. You can test at
https://gerrit-test.wikimedia.org/
It holds a copy of our Gerrit data as of 15th of June, and it runs the new Gerrit v3.2.2. We'll keep tuning things there during this week, so it might get an occasional restart. But look around and test the new UI, the HTTP API, etc.
If you run into issues or discover bugs, please open tickets in Phabricator and set the Gerrit 3.x upgrade task (T254158) as parent.
Note that this test Gerrit instance is already hooked up with our Phabricator. If you upload / merge / abandon / etc changes with a `Bug: Tnnnn` footer, you'll get comments on the corresponding tasks in Gerrit. So please use our test task T775 for your experiments.
As everything, also this upgrade comes with a few downsides:
- The new UI no longer works on Internet Explorer (currently ~0.02% of
Gerrit's web requests). Microsoft's Edge browser works though. So if you are still using Internet Explorer, please consider switching to a different browser.
- Users of git-review need to use at least version 1.27 (released
September 2018). Otherwise uploading changes will fail.
- Your git should be at least version 2.2.0 (released November 2014)
to take advantage of the new, much simpler commit-msg hook.
Keeping my fingers crossed for a painless update, Christian with lots of helping hands from RelEng, and SRE
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
When I go to any patch I see the non-fatal error "Plugin install error: TypeError: self.onAction is not a function from https://gerrit.wikimedia.org/r/plugins/delete-project/static/delete-project.... "
I was about to create a Phabricator task for this, then realized the issue was my browser's cache. So if you run into this try clearing your cache.
Thanks for all the hard work, all!
~ MA
On Sat, Jun 27, 2020 at 4:29 PM Christian Aistleitner via Wikitech-l < wikitech-l@lists.wikimedia.org> wrote:
Hi,
The Gerrit upgrade finished, and the new and shiny Gerrit v3.2.2 is live now on gerrit.wikimedia.org and is good to use again.
Please test and if you run into issues, don't hesitate to file a ticket in Phabricator (Bonus points for adding the 'Gerrit' project and/or making T254158 a parent task)
Huge thanks to all the people who helped. Foremost mutante and paladox who both spent countless hours to prepare the upgrade. Also hashar whose help around CI and deployment was invaluable. And all the other hands who helped in preparing and deploying: thcipriani, jynus, marostegui, godog and all whom I've forgotten. This was a huge team effort. Thanks all!
Have fun, Christian
On Sat, Jun 20, 2020 at 11:58:23PM +0200, Christian Aistleitner via Wikitech-l wrote:
[Apologies for cross-posting]
Hi,
TL;DR: We will take our Gerrit instance at gerrit.wikimeda.org offline on Saturday, 27th of June from 17:00--22:00 UTC (hopefully much shorter) to upgrade to the latest Gerrit v3.2.2.
(10:00--15:00 San Francisco time, and 19:00--24:00 Central European time)
We're currently running Gerrit v2.15, which is no longer supported and we will upgrade to Gerrit v3.2 on Saturday 27th of June. This new version brings lots of improvements. The most noticeable change is probably the UI overhaul. The (default) "old UI" gets removed and the "new UI" has been completely revamped. It's much more modern looking and easier to use. And it also became far more usable on mobile phones. But the new version of course also comes with fixes and additions around the ssh interface, and the HTTP API.
Since this is such a big upgrade, we want to give you a chance to look at it beforehand. You can test at
https://gerrit-test.wikimedia.org/
It holds a copy of our Gerrit data as of 15th of June, and it runs the new Gerrit v3.2.2. We'll keep tuning things there during this week, so it might get an occasional restart. But look around and test the new UI, the HTTP API, etc.
If you run into issues or discover bugs, please open tickets in Phabricator and set the Gerrit 3.x upgrade task (T254158) as parent.
Note that this test Gerrit instance is already hooked up with our Phabricator. If you upload / merge / abandon / etc changes with a `Bug: Tnnnn` footer, you'll get comments on the corresponding tasks in Gerrit. So please use our test task T775 for your experiments.
As everything, also this upgrade comes with a few downsides:
- The new UI no longer works on Internet Explorer (currently ~0.02% of
Gerrit's web requests). Microsoft's Edge browser works though. So if you are still using Internet Explorer, please consider switching to a different browser.
- Users of git-review need to use at least version 1.27 (released
September 2018). Otherwise uploading changes will fail.
- Your git should be at least version 2.2.0 (released November 2014)
to take advantage of the new, much simpler commit-msg hook.
Keeping my fingers crossed for a painless update, Christian with lots of helping hands from RelEng, and SRE
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
-- ---- quelltextlich e.U. ---- \ ---- Christian Aistleitner ---- Companies' registry: 360296y in Linz Christian Aistleitner Kefermarkterstrasze 6a/3 Email: christian@quelltextlich.at 4293 Gutau, Austria Phone: +43 7946 / 20 5 81 Fax: +43 7946 / 20 5 81 Homepage: http://quelltextlich.at/
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Hello, you need to clear you web cache (e.g hard refresh). On Saturday, 27 June 2020, 21:58:47 BST, MusikAnimal musikanimal@gmail.com wrote:
When I go to any patch I see the non-fatal error "Plugin install error: TypeError: self.onAction is not a function from https://gerrit.wikimedia.org/r/plugins/delete-project/static/delete-project...." I was about to create a Phabricator task for this, then realized the issue was my browser's cache. So if you run into this try clearing your cache. Thanks for all the hard work, all! ~ MA On Sat, Jun 27, 2020 at 4:29 PM Christian Aistleitner via Wikitech-l wikitech-l@lists.wikimedia.org wrote:
Hi,
The Gerrit upgrade finished, and the new and shiny Gerrit v3.2.2 is live now on gerrit.wikimedia.org and is good to use again.
Please test and if you run into issues, don't hesitate to file a ticket in Phabricator (Bonus points for adding the 'Gerrit' project and/or making T254158 a parent task)
Huge thanks to all the people who helped. Foremost mutante and paladox who both spent countless hours to prepare the upgrade. Also hashar whose help around CI and deployment was invaluable. And all the other hands who helped in preparing and deploying: thcipriani, jynus, marostegui, godog and all whom I've forgotten. This was a huge team effort. Thanks all!
Have fun, Christian
On Sat, Jun 20, 2020 at 11:58:23PM +0200, Christian Aistleitner via Wikitech-l wrote:
[Apologies for cross-posting]
Hi,
TL;DR: We will take our Gerrit instance at gerrit.wikimeda.org offline on Saturday, 27th of June from 17:00--22:00 UTC (hopefully much shorter) to upgrade to the latest Gerrit v3.2.2.
(10:00--15:00 San Francisco time, and 19:00--24:00 Central European time)
We're currently running Gerrit v2.15, which is no longer supported and we will upgrade to Gerrit v3.2 on Saturday 27th of June. This new version brings lots of improvements. The most noticeable change is probably the UI overhaul. The (default) "old UI" gets removed and the "new UI" has been completely revamped. It's much more modern looking and easier to use. And it also became far more usable on mobile phones. But the new version of course also comes with fixes and additions around the ssh interface, and the HTTP API.
Since this is such a big upgrade, we want to give you a chance to look at it beforehand. You can test at
https://gerrit-test.wikimedia.org/
It holds a copy of our Gerrit data as of 15th of June, and it runs the new Gerrit v3.2.2. We'll keep tuning things there during this week, so it might get an occasional restart. But look around and test the new UI, the HTTP API, etc.
If you run into issues or discover bugs, please open tickets in Phabricator and set the Gerrit 3.x upgrade task (T254158) as parent.
Note that this test Gerrit instance is already hooked up with our Phabricator. If you upload / merge / abandon / etc changes with a `Bug: Tnnnn` footer, you'll get comments on the corresponding tasks in Gerrit. So please use our test task T775 for your experiments.
As everything, also this upgrade comes with a few downsides:
- The new UI no longer works on Internet Explorer (currently ~0.02% of
Gerrit's web requests). Microsoft's Edge browser works though. So if you are still using Internet Explorer, please consider switching to a different browser.
- Users of git-review need to use at least version 1.27 (released
September 2018). Otherwise uploading changes will fail.
- Your git should be at least version 2.2.0 (released November 2014)
to take advantage of the new, much simpler commit-msg hook.
Keeping my fingers crossed for a painless update, Christian with lots of helping hands from RelEng, and SRE
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Hi,
On Sat, Jun 27, 2020 at 04:57:46PM -0400, MusikAnimal wrote:
When I go to any patch I see the non-fatal error "Plugin install error: TypeError: self.onAction is not a function from https://gerrit.wikimedia.org/r/plugins/delete-project/static/delete-project.... "
I was about to create a Phabricator task for this, then realized the issue was my browser's cache. So if you run into this try clearing your cache.
It seems for some the Ctrl + F5 or Stift + Ctrl + F5 (or whatever combination your browser wants) was not sufficient.
If you still run into the issue after pressing your browsers F5 combination, please try clearing your caches for good.
For example on Firefox follow steps 1-6 from
https://support.mozilla.org/en-US/kb/how-clear-firefox-cache#w_clear-the-cac...
(If you use a different browser, it should allow you to clear cached web content somewhere in the setting too. Please find that in your browser's help pages and follow the instructions)
Have fun, Christian
P.S.: Thanks to Legoktm for debugging that with me!