Oh, yes! I would prefer the codemirror plugin, just that you can edit without it :) On Sunday, 21 June 2020, 20:03:45 BST, Christian Aistleitner christian@quelltextlich.at wrote:
Hi,
On Sun, Jun 21, 2020 at 02:46:48PM +0000, Paladox via Cloud wrote:
the code mirror plugin isn't really needed to edit, since pg falls back to the default editor.
While you're right that the default editor is there, it is severely lacking [1] and it's far worse than what our current old Gerrit v2.15 offered in the GWT part.
The `codemirror-editor` plugin typically comes bundled with Gerrit, is trivially small and it was my list to set it up for the test Gerrit.
Regardless of whether we call the default editor fit for file-editing or not, can we agree that the codemirror-editor is so much better that it's worth to have this simple plugin? ;-)
Have fun, Christian
[1] Even the Googlers don't want it [2]:
I think that, for now, the minimum requirement for me to be happy setting the editing experience live is a functional CodeMirror editor with working syntax highlighting. As of right now, the editor built into PolyGerrit is mostly just for debugging -- it doesn't properly capture tabs [...]
And since that quote is from 2017, I retried and it still cannot even do tabs properly. That's a no go.
[2] https://bugs.chromium.org/p/gerrit/issues/detail?id=4437