Hi,
while taking some jobs off of Hadoop, I realized that some of our pig scripts rely on
geoip-1.2.9-patch-2-SNAPSHOT.jar
, although only the patch-1 variant is provided in maven central [1], and on our nexus [2]. We also do not have a publicly visible fork of geoip in gerrit [3]. The patch-2 only exists in our hadoop [4] cluster.
How do we build that jar? What extra patches are in there?
Best regards, Christian
[1] http://search.maven.org/#browse%7C1125542321 [2] http://nexus.wmflabs.org/nexus/index.html#nexus-search;quick~geoip [3] https://gerrit.wikimedia.org/r/#/admin/projects/?filter=geo [4] See /libs/geoip-1.2.9-patch-2-SNAPSHOT.jar in hadoop
On Mon, Aug 19, 2013 at 11:26 AM, Christian Aistleitner < christian@quelltextlich.at> wrote:
Hi,
while taking some jobs off of Hadoop, I realized that some of our pig scripts rely on
geoip-1.2.9-patch-2-SNAPSHOT.jar
, although only the patch-1 variant is provided in maven central [1], and on our nexus [2]. We also do not have a publicly visible fork of geoip in gerrit [3]. The patch-2 only exists in our hadoop [4] cluster.
How do we build that jar?
IIRC, it is build from https://github.com/kohsuke/geoip
What extra patches are in there?
Contains a number of bug fixes for NullPointerExceptions for specific ip addresses.
Best regards, Christian
[1] http://search.maven.org/#browse%7C1125542321 [2] http://nexus.wmflabs.org/nexus/index.html#nexus-search;quick~geoip [3] https://gerrit.wikimedia.org/r/#/admin/projects/?filter=geo [4] See /libs/geoip-1.2.9-patch-2-SNAPSHOT.jar in hadoop
-- ---- quelltextlich e.U. ---- \ ---- Christian Aistleitner ---- Companies' registry: 360296y in Linz Christian Aistleitner Gruendbergstrasze 65a Email: christian@quelltextlich.at 4040 Linz, Austria Phone: +43 732 / 26 95 63 Fax: +43 732 / 26 95 63 Homepage: http://quelltextlich.at/
Hi Diederik,
On Mon, Aug 19, 2013 at 11:34:28AM -0400, Diederik van Liere wrote:
On Mon, Aug 19, 2013 at 11:26 AM, Christian Aistleitner < christian@quelltextlich.at> wrote:
geoip-1.2.9-patch-2-SNAPSHOT.jar [...]
How do we build that jar?
IIRC, it is build from https://github.com/kohsuke/geoip
Yes, that's was also my guess from the version number.
However, current master of the above repository differs from geoip-1.2.9-patch-1 only in a single commit. And this single commit does nothing but bump the version number [1].
So I got curious and thought that we probably would not switch from a proper released and stable jar to some ever changing snapshot just to get a different version number. That would not make much sense.
Hence, I thought that maybe there were some extra patches somewhere.
What extra patches are in there?
Contains a number of bug fixes for NullPointerExceptions for specific ip addresses.
Awesome! Where are those patches?
Best regards, Christian
[1] https://github.com/kohsuke/geoip/commit/3f8767369d6f610c45c77e98e97089085797...
On Mon, Aug 19, 2013 at 1:59 PM, Christian Aistleitner < christian@quelltextlich.at> wrote:
Hi Diederik,
On Mon, Aug 19, 2013 at 11:34:28AM -0400, Diederik van Liere wrote:
On Mon, Aug 19, 2013 at 11:26 AM, Christian Aistleitner < christian@quelltextlich.at> wrote:
geoip-1.2.9-patch-2-SNAPSHOT.jar [...]
How do we build that jar?
IIRC, it is build from https://github.com/kohsuke/geoip
Yes, that's was also my guess from the version number.
However, current master of the above repository differs from geoip-1.2.9-patch-1 only in a single commit. And this single commit does nothing but bump the version number [1].
So I got curious and thought that we probably would not switch from a proper released and stable jar to some ever changing snapshot just to get a different version number. That would not make much sense.
Hence, I thought that maybe there were some extra patches somewhere.
What extra patches are in there?
Contains a number of bug fixes for NullPointerExceptions for specific ip addresses.
Awesome! Where are those patches?
I misunderstood, i was referring to the fixes in 1.2.9; there are no additional patches on top of that. D
Best regards, Christian
[1] https://github.com/kohsuke/geoip/commit/3f8767369d6f610c45c77e98e97089085797...
-- ---- quelltextlich e.U. ---- \ ---- Christian Aistleitner ---- Companies' registry: 360296y in Linz Christian Aistleitner Gruendbergstrasze 65a Email: christian@quelltextlich.at 4040 Linz, Austria Phone: +43 732 / 26 95 63 Fax: +43 732 / 26 95 63 Homepage: http://quelltextlich.at/
Hi,
On Mon, Aug 19, 2013 at 02:07:29PM -0400, Diederik van Liere wrote:
[...] there are no additional patches on top of that.
Oh, that's good to know. Thanks.
I guess this means that the released geoip-1.2.9-patch-1 jar and our geoip-1.2.9-patch-2 jar should be functional equivalent? So just that we do not forget, I created card #1080 [1] to downgrade the geoip jar used by kraken to the kohsuke's released version.
Downgrading would lessen our maintenance burden, and make it easier to run the pig scripts.
Best regards, Christian
[1] https://mingle.corp.wikimedia.org/projects/analytics/cards/1080