Sent from my iPhone
On 2013-01-26, at 2:22, Matthew Flaschen mflaschen@wikimedia.org wrote:
On 01/25/2013 12:41 PM, Diederik van Liere wrote:
Apologies for crossposting
Heya,
The Analytics Team is planning to deploy "tab as field delimiter" to replace the current space as fielddelimiter on the varnish/squid/nginx servers.
I don't know either way if any other code is affected. But I'm wondering, what will happen if the input (e.g. a header value) contains a tab? Is it sanitized by Varnish/Squid/nginx?
Hey Matt This is exactly the reason why we want to move from space to tab as field delimiter. Spaces occur frequently in a header value and it requires us to writes patches for squid/varnish/Nginx to escape the spaces. Writing these patches happened very infrequently and is cumbersome because you need to do it three times.
Now there could be a tab in a header value as well but I have never seen it in our logfiles and i also grepped for it on a couple of random files and found no such occurrences. So we are not going to escape tab characters in fields unless new information changes our mind.
Best D
Matt Flaschen
Analytics mailing list Analytics@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/analytics