[teampractices] Code review before writing new code

[Quim Gil]

On Mon, Jun 8, 2015 at 12:35 PM, Antoine Musso <hashar+wmf at free.fr> wrote:

> When I look at the korma page, the two first pages are for MediaWiki
> extensions that have been abandoned ages ago.  Either because it was a
> one time proof of concept or it has migrated to GitHub.   If we could
> archive / move to an attic all the bitrotting repositories that will
> surely help.
>

If that is true, then the old open reviews that are making those
repositories show up can be safely abandoned, right? There is no point in
keeping open reviews in abandoned / migrated repositories.


> mediawiki/core itself has 500+ open changes or a good third of the debt.
>   If one could generate a list of changes per authors and then ask each
> author to move its patches forward, that would help.
>
> Remember the main reason to have a premerge review workflow was to put
> the responsibility of review in the hands of the author.  If people
> don't babysit their patches, there is not much we can do I guess.
>

As said, -1 and WIP are already filtered in those metrics. The patches you
see are either 0 or +1. The way to tell authors to move patches forward is
by posting -1 with a comment of what is missing.

-- 
Quim Gil
Engineering Community Manager @ Wikimedia Foundation
http://www.mediawiki.org/wiki/User:Qgil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.wikimedia.org/pipermail/teampractices/attachments/20150608/001ea39e/attachment.html>