[teampractices] Code review before writing new code

[James Douglas]

> "A team should review their open patchsets before writing new code."

+1, this is a great way to remind ourselves to focus on priorities.

This is also basic product management; if I'm working on B while the patch
for A sits around unused, I'm implying that B is a higher priority than A.
That may be true -- priorities do change from time to time, but maybe not.
Either way, it's a loud signal that I might need to contact my PM for
clarification, or my Scrum master to help clear the blocker on A.


On Mon, Jun 8, 2015 at 3:42 AM, Quim Gil <qgil at wikimedia.org> wrote:

>
>
> On Mon, Jun 8, 2015 at 12:35 PM, Antoine Musso <hashar+wmf at free.fr> wrote:
>
>> When I look at the korma page, the two first pages are for MediaWiki
>> extensions that have been abandoned ages ago.  Either because it was a
>> one time proof of concept or it has migrated to GitHub.   If we could
>> archive / move to an attic all the bitrotting repositories that will
>> surely help.
>>
>
> If that is true, then the old open reviews that are making those
> repositories show up can be safely abandoned, right? There is no point in
> keeping open reviews in abandoned / migrated repositories.
>
>
>> mediawiki/core itself has 500+ open changes or a good third of the debt.
>>   If one could generate a list of changes per authors and then ask each
>> author to move its patches forward, that would help.
>>
>> Remember the main reason to have a premerge review workflow was to put
>> the responsibility of review in the hands of the author.  If people
>> don't babysit their patches, there is not much we can do I guess.
>>
>
> As said, -1 and WIP are already filtered in those metrics. The patches you
> see are either 0 or +1. The way to tell authors to move patches forward is
> by posting -1 with a comment of what is missing.
>
> --
> Quim Gil
> Engineering Community Manager @ Wikimedia Foundation
> http://www.mediawiki.org/wiki/User:Qgil
>
> _______________________________________________
> teampractices mailing list
> teampractices at lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/teampractices
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.wikimedia.org/pipermail/teampractices/attachments/20150608/2791480c/attachment.html>