[teampractices] Code review social norms

Mukunda Modell mmodell at wikimedia.org
Wed Mar 16 03:03:48 UTC 2016


On Tue, Mar 15, 2016 at 6:48 PM, Kevin Smith <ksmith at wikimedia.org> wrote:

>
> I would mention that in some cases, I would prefer to accept the commit as
> is, and then perform minor refactoring, such as changing a name, fixing a
> typo, or rearranging the code. Not only does that clearly separate
> authorship, but it would also encourage those changes to be reviewed by
> someone other than that author.
>
> Kevin Smith
> Agile Coach, Wikimedia Foundation
>
>
>

This ^

I think this says what I've been trying to say, only better.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.wikimedia.org/pipermail/teampractices/attachments/20160315/794c8712/attachment-0001.html>


More information about the teampractices mailing list