[teampractices] Patch review culture of Wikimedia teams

[Kevin Smith]

I'll speak for myself, while boldly/foolishly projecting some guesses onto
the rest of TPG as well.

TPG generally focuses on process and inter-personal issues, and doesn't get
into the tech itself. So our focus tends to be at the phab task level,
rather than at the gerrit patch level. I'm happy to hear that Dan monitors
the patches, although I wouldn't be surprised if he is unusual in doing so
(among product managers), because he has a very technical background.

I think most TPGers happen to be embedded into teams that receive
relatively few external code submissions.

I wonder whether integrating code review into phab will give us some new
tools to help teams more easily monitor the flow of patches. I don't know
what tools are available in gerrit.




Kevin Smith
Agile Coach, Wikimedia Foundation


On Mon, Mar 14, 2016 at 6:19 AM, Andre Klapper <aklapper at wikimedia.org>
wrote:

> Thanks everybody for the comments! However I'm still curious if this is
> part of the TPG scope, hence I'd welcome a reply from TPG members.
>
> Thanks,
> andre
>
> On Mon, 2016-03-07 at 14:16 +0100, Andre Klapper wrote:
> > https://phabricator.wikimedia.org/T101686 lists "Prioritization / weak
> > open source culture: more pressure to write new code than to review
> > patches contributed."
> >
> > Apart from whether that statement is true or not:
> > Does the Team Practices Group encourage regular Gerrit patch backlog
> > grooming? If so, how, and is there any documentation available, or even
> > data which teams perform better or worse? Is there any differentiation
> > between "internal" patches by team members vs. contributed patches?
> > Or is this out of scope for TPG?
>
> --
> Andre Klapper | Wikimedia Bugwrangler
> http://blogs.gnome.org/aklapper/
>
>
>
> _______________________________________________
> teampractices mailing list
> teampractices at lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/teampractices
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.wikimedia.org/pipermail/teampractices/attachments/20160315/ab0cab99/attachment-0001.html>