[QA] T86359: Updating jenkins for extension registration changes

Legoktm legoktm.wikipedia at gmail.com
Thu Feb 5 00:37:49 UTC 2015

On 02/03/2015 12:00 PM, Antoine Musso wrote:

> Beside a quick look I gave to it on Jan 16th [1], I do not have any
> spare cycles to context switch to the extension registration RFC and its
> wfLoadExtensions() implementation.  Maybe the patches are just fine, but
> I would need a couple hours to investigate/test them more deeply.

If you are busy, who else can I add as a reviewer to look at them to
hopefully merge & deploy?

>> * Run validateRegistrationFile.php whenever a extension/skin.json is
>> modified (similar to the php-composer-validate job).
> You can convert it / invoke it from the MediaWiki core PHPUnit
> 'structure' suite under tests/phpunit/structure . The structure suite is
> now included by the PHPUnit job run on extensions:

I'm not sure this will work. If the extension.json file is invalid,
errors might be thrown before the unit test can even be run when it
attempts to load the extension.

>>  * This depends upon an external library, what would be the best
>> way to implement this?
> Assuming we have core, we would have vendor as well. So maybe ship it in
> vendor.

mediawiki/vendor is for libraries that are needed by core and
WMF-deployed extensions in production. The JSON schema library the
script depends on should never be used in production, only while
developing code.

-- Legoktm

More information about the QA mailing list