[QA] Pair programming[Friday (27th June 2014)] with Zeljkof

Vikas Yaligar vikasyaligar.it at gmail.com
Sun Jun 29 22:12:27 UTC 2014


Last week I had paired with Zeljko on Monday, Tuesday, Thursday and Friday.
Here is what we did on Friday:

* I had some problems in getting cropped screenshot for elements inside an
iframe, reason for it was, elements which are inside iframe, return their
co-ordinates with respect to the iframe rather than the browser window.

* Hence to solve this we decided to pass another argument(offset_rectangle)
to rectangle method which we had written before.

* We wrote some tests for it and then got it passing, just by adding of x
co-ordinates and y co-ordinates of the cropped screenshot with iframe

* One interesting thing, which we changed was the argument variable in
methods, when optional we tend to make it nil, but here we used it as an
empty rectangle(i.e. [0, 0, 0, 0]) so that the code becomes smaller and

Thank you Zeljko, for pairing with me last week. I had amazing time with
you reviewing this code :) Now I have realized what exactly is expected
when one looks into the code. Let me know if I have missed anything in last
weeks reports.

Vikas S Yaligar
IT Department
NITK Surathkal
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wikimedia.org/pipermail/qa/attachments/20140630/af0cc048/attachment.html>

More information about the QA mailing list