[QA] Reg::RSpec matchers

Dan Duvall dduvall at wikimedia.org
Tue Jul 15 17:12:19 UTC 2014


Just to clarify, AFAIK the predicate matcher
<https://www.relishapp.com/rspec/rspec-expectations/v/3-0/docs/built-in-matchers/predicate-matchers>
syntax has not changed, so there's no need to change `be_visible`. As
Zeljko has illustrated, it's only the expectation syntax
<https://www.relishapp.com/rspec/rspec-expectations/docs> that needs
refactoring.


On Tue, Jul 15, 2014 at 1:07 AM, jagori samajdar <jagori79 at gmail.com> wrote:

> Thanks Zeljko for helping me out with the conversion part.I was thinking ,
> how to convert a single line statement like this:)
>
> But I still remain confused about the documentation.
>
> If anybody could provide any other documentation would be wonderful.
> Thanks,
> jagori
>
>
> On Mon, Jul 14, 2014 at 10:21 PM, Željko Filipin <zfilipin at wikimedia.org>
> wrote:
>
>> On Mon, Jul 14, 2014 at 11:28 AM, jagori samajdar <jagori79 at gmail.com>
>> wrote:
>>
>>> As part of my task wherein am converting the should syntax to expect,am
>>> bit confused with the *be_visible* matcher or whatever it is.
>>>
>>
>> For those of you that are not familiar with the bug, it is 66369[1].
>>
>>
>>> I couldn't see it anywhere in the RSpec's default built in matcher list.
>>> https://github.com/rspec/rspec-expectations
>>>
>>> Can anyone help me understand the same as in the pasted code defined in
>>> options_steps.rb:
>>>
>>> Then(/^I should see the options overlay$/) do
>>>   on(VisualEditorPage).options_page_title_element.when_present.should
>>> be_visible
>>> end
>>>
>>
>> In this case, you have to convert
>>
>> on(VisualEditorPage).options_page_title_element.when_present.should
>> be_visible
>>
>> to
>>
>>
>> expect((VisualEditorPage).options_page_title_element.when_present).to be_visible
>>
>> Let me know if you are still confused, or if you need more documentation.
>> If anybody can point to better documentation than I have provided in the
>> last e-mail message, please do.
>>
>> Željko
>> --
>> https://bugzilla.wikimedia.org/show_bug.cgi?id=66369
>>
>> _______________________________________________
>> QA mailing list
>> QA at lists.wikimedia.org
>> https://lists.wikimedia.org/mailman/listinfo/qa
>>
>>
>
> _______________________________________________
> QA mailing list
> QA at lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/qa
>
>


-- 
Dan Duvall
Automation Engineer
Wikimedia Foundation <http://wikimediafoundation.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wikimedia.org/pipermail/qa/attachments/20140715/6a9b7d9d/attachment.html>


More information about the QA mailing list