[QA] Gerrit/QA/BrowserTests rights and one other silly question

[Chris McMahon]

Perfect!

After you added me as a reviewer, I got an email just now with the title
"[Gerrit] Refactoring: class UserPage renamed to VisualEditorPage - change
(qa/browsertests)"

I clicked on "Diff" on the page at https://gerrit.wikimedia.org/r/#/c/67865/ to
see what had changed and everything looked good.

But just to make sure, I want to run the test with these changes myself, so
I did:

$ git clone ssh://cmcmahon@gerrit.wikimedia.org:29418/qa/browsertests
$ cd browsertests/
$ git review -d 67865

This brings Tomislav's branch down to my local machine.

Then I do

bundle exec cucumber features/visual_editor.feature

to run the test.  But it fails!  Of course, I forgot that the default test
environment on any local machine is on beta labs at
http://en.wikipedia.beta.wmflabs.org, but looking at the top of the
visual_editor.feature file, VisualEditor tests only run on test2wiki at
http://test2.wikipedia.org .

So I do this to point my test to the correct test environment and run the
test again:

$ export MEDIAWIKI_URL=http://test2.wikipedia.org/wiki/
$ bundle exec cucumber features/visual_editor.feature

The test passes, everything looks good.  I merged the change.

Thanks Tomislav!
-Chris






 2049  export MEDIAWIKI_URL=http://test2.wikipedia.org/wiki/
 2050  bundle exec cucumber features/visual_editor.feature


On Mon, Jun 10, 2013 at 1:47 PM, Chris McMahon <cmcmahon at wikimedia.org>wrote:

>
>
>
> On Mon, Jun 10, 2013 at 1:16 PM, Tomislav Plavcic <tplavcic at gmail.com>wrote:
>
>>  On 10.06.2013 18:09, Chris McMahon wrote:
>>
>> O.K. Git now works for me - I made a mistake (of not reading tutorial)
>> and didn't use "git review" but "git push" command... :(
>>
>>
>> Great!
>
> I see your commit at https://gerrit.wikimedia.org/r/#/c/67865/
>
> Now I would like you to visit that page in gerrit, find the text box and
> the button for "Add reviewer".   Put "cmcmahon" in the text box (you should
> see auto-complete), click "Add reviewer", then put "zfilipin" too.  Add
> anyone else you'd like:  right now only Željko and I have privileges to
> merge code in the qa/ repository.  (But we'd like to change that pretty
> soon.)
>
> When you add a reviewer, that person automatically gets email that there
> is a code change in gerrit for them to review.
>
> Historically a big part of "Quality Assurance" for Wikipedia has relied on
> code review.  Code review is an important part of how we make software at
> WMF.  Unfortunately gerrit is not the most intuitive code review tool in
> the world, but we adopted gerrit for many good reasons.  It is worth
> learning.
> -Chris
>
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wikimedia.org/pipermail/qa/attachments/20130610/85616295/attachment-0001.html>