<div dir="ltr"><div><br></div>Perfect! <div><br></div><div>After you added me as a reviewer, I got an email just now with the title "[Gerrit] Refactoring: class UserPage renamed to VisualEditorPage - change (qa/browsertests)"</div>
<div><br></div><div>I clicked on "Diff" on the page at <a href="https://gerrit.wikimedia.org/r/#/c/67865/">https://gerrit.wikimedia.org/r/#/c/67865/</a> to see what had changed and everything looked good. </div>
<div><br></div><div style>But just to make sure, I want to run the test with these changes myself, so I did: </div><div style><br></div><div style><div>$ git clone ssh://<a href="http://cmcmahon@gerrit.wikimedia.org:29418/qa/browsertests">cmcmahon@gerrit.wikimedia.org:29418/qa/browsertests</a></div>
<div>$ cd browsertests/</div><div>$ git review -d 67865</div><div><br></div><div style>This brings Tomislav's branch down to my local machine. </div><div style><br></div><div style>Then I do </div><div style><br></div>
<div style><div>bundle exec cucumber features/visual_editor.feature </div><div><br></div><div style>to run the test. But it fails! Of course, I forgot that the default test environment on any local machine is on beta labs at <a href="http://en.wikipedia.beta.wmflabs.org/">http://en.wikipedia.beta.wmflabs.org</a>, but looking at the top of the visual_editor.feature file, VisualEditor tests only run on test2wiki at <a href="http://test2.wikipedia.org/">http://test2.wikipedia.org</a> .</div>
<div style><br></div><div style>So I do this to point my test to the correct test environment and run the test again:</div><div style><br></div><div>$ export MEDIAWIKI_URL=<a href="http://test2.wikipedia.org/wiki/">http://test2.wikipedia.org/wiki/</a></div>
<div>$ bundle exec cucumber features/visual_editor.feature </div><div><br></div><div style>The test passes, everything looks good. I merged the change. </div><div style><br></div><div style>Thanks Tomislav! </div><div style>
-Chris </div><div style> </div><div style><br></div><div style><br></div><div style><br></div><div style><br></div><div><br></div><div> 2049 export MEDIAWIKI_URL=<a href="http://test2.wikipedia.org/wiki/">http://test2.wikipedia.org/wiki/</a></div>
<div> 2050 bundle exec cucumber features/visual_editor.feature</div></div></div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jun 10, 2013 at 1:47 PM, Chris McMahon <span dir="ltr"><<a href="mailto:cmcmahon@wikimedia.org" target="_blank">cmcmahon@wikimedia.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">
<div class="im">On Mon, Jun 10, 2013 at 1:16 PM, Tomislav Plavcic <span dir="ltr"><<a href="mailto:tplavcic@gmail.com" target="_blank">tplavcic@gmail.com</a>></span> wrote:<br>
</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"><div class="im"><div>
<div>On 10.06.2013 18:09, Chris McMahon
wrote:<br>
</div>
<br></div></div><div class="im">
O.K. Git now works for me - I made a mistake (of not reading
tutorial) and didn't use "git review" but "git push" command... :(<div><br>
</div><div><br></div></div></div></blockquote><div>Great!</div><div> </div><div>I see your commit at <a href="https://gerrit.wikimedia.org/r/#/c/67865/" target="_blank">https://gerrit.wikimedia.org/r/#/c/67865/</a> <br>
</div><div><br></div><div>Now I would like you to visit that page in gerrit, find the text box and the button for "Add reviewer". Put "cmcmahon" in the text box (you should see auto-complete), click "Add reviewer", then put "zfilipin" too. Add anyone else you'd like: right now only Željko and I have privileges to merge code in the qa/ repository. (But we'd like to change that pretty soon.) </div>
<div><br></div><div>When you add a reviewer, that person automatically gets email that there is a code change in gerrit for them to review.</div><div><br></div><div>Historically a big part of "Quality Assurance" for Wikipedia has relied on code review. Code review is an important part of how we make software at WMF. Unfortunately gerrit is not the most intuitive code review tool in the world, but we adopted gerrit for many good reasons. It is worth learning. </div>
<span class=""><font color="#888888">
<div>-Chris </div><div><br></div><div><br></div><div><br></div></font></span></div><br></div></div>
</blockquote></div><br></div></div></div>