----- Original Nachricht ----
Von: "Dr. Trigon" <dr.trigon(a)surfeu.ch>
An: pywikipedia-l(a)lists.wikimedia.org
Datum: 01.08.2013 11:03
Betreff: Re: [Pywikipedia-l] Question about externals and patches
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 01.08.2013 05:37, info(a)gno.de wrote:
There is a remaining bug. Try the following e.g.
from idle:
>> import Wikipedia
you are asked to install patch.exe. If you decline this request you
are asked a second time. If declined a second time the script
raises a fatal error while importing beautifullsoup. Beautifullsoup
is a central part if the screen scraping compat framework and we
should not prohibit using the framework for a cosmetic patch.
Please give us back that part as e.g. externals or a library
script. Anyway it is not a good idea to ask for installation
(twice) and fall into a fatal error if you answer is NO. There
should be alternatives to patching the working copy (e.g. nightly
dump etc.)
Thank you very much for this info! I will look at this as soon as
possible!
The question is how to handle the case you descibed? This questions
have to be regarded as final part of the install/setup process
(checkout, clone or download), so how to handle a sequence of N(o)
answers? In fact this means that the user does not want to finish the
install/setup process - this is somehow a paradox... Shall I simply
output a message:
"Install process could not be finished, framework NOT ready for use!"
Please contribute your ideas! externals/__init__.py is supposed to
help us, not to bother us... :) By the way the concept is not new, is
was inspired by how "VisTrails" does this.
Thanks and Greetings
DrTrigon
I don't like any installation process including rewrite branch/core and I am using
pwb.py to have a directory based environment. Maybe for some reasons a installation is
necessary but it should be very rare! There is no reason for patching beautifullsoup
because we could either use the external library (as something like external) as it is or
include it to the framework as it was previously. This is a central library for the compat
branch and you cannot run it whithout that stuff. Missing this library stops running the
whole framework if some users did not want to install any .exe file. Other patches only
depends few scripts or not even a script is affected.
And please check whether a patch is necessary for other parts too and keep the code
simple. I guess there could be other ways which have the same effect without running any
.exe file which some people don't like to. E.g. for music21, pydmtx, zbar I don't
understand why a patch is required (and for what scripts they are needed at all).
best
xqt