-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 02.02.2012 23:14, Merlijn van Deen wrote:
Heh, you're right. However, that .request method is probably easier to split (as it's smaller and simpler): lines 100-119 should just be split off into a seperate function.
http://svn.wikimedia.org/viewvc/pywikipedia/branches/rewrite/pywikibot/comms...
Looks very nice and well coded thus (as you mentioned) I used this structure.
That would be great. I'd suggest to use the structure - and if possible the code - from the rewrite, making the API for both branches as similar as possible.
http://svn.wikimedia.org/viewvc/pywikipedia/trunk/pywikipedia/pywikibot/comm...
I tried to make them as similar as possible in r9901 [1] but the differ fundamentally which makes full adoption somehow hard. I would sugest to use the current one, to check if the code move worked (and did not introduce errors) and afterwards (some time later) adopt it further to be more "rewrite-ish"... (may be that step should be done by someone familar with trunk AND rewrite - as I am using trunk only... ;)
[1] http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9901
Hope that suits you fine?
Greetings DrTrigon