jayvdb added a comment.
The code from compat is
``` def url2link(percentname, insite, site): """Convert urlname of a wiki page into interwiki link format.
'percentname' is the page title as given by Page.urlname(); 'insite' specifies the target Site; 'site' is the Site on which the page is found.
""" # Note: this is only needed if linking between wikis that use different # encodings, so it is now largely obsolete. [CONFIRM] percentname = percentname.replace('_', ' ') x = url2unicode(percentname, site=site) return unicode2html(x, insite.encoding()) ```
As welcome bot only works on a single site, it does not need to use this function, and should be updated to use existing methods.
checkimages does also access Wikimedia Commons, but as far as I can see Wikimedia Commons is not related to the call to function url2link, so again I think the code should be updated.
url2link should be added to README-conversion.txt / scripts/maintenance/compat2core.py , or it would also be useful to copy the missing function url2link from compat, and mark it as deprecated, so that old compat scripts work correctly.
TASK DETAIL https://phabricator.wikimedia.org/T75017
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: jayvdb Cc: pywikipedia-bugs, jayvdb