----- Original Nachricht ---- Von: Merlijn van Deen valhallasw@arctus.nl An: Pywikipedia discussion list pywikipedia-l@lists.wikimedia.org Datum: 10.08.2013 16:13 Betreff: Re: [Pywikipedia-l] Code review in gerrit
On 2 August 2013 08:52, info@gno.de wrote:
Ok (or to bad). I am just for a tool stuff reminder for "this part of
code
has still remaining bugs" (fixme) and when it is solved mark it as
solved.
I assume we must use the bug tracker for that which is not very
comfortable
(at least of the last changes at sf ihmo).
I think the basic workflow would be to fix those bugs before merging the code. Of course, it could be possible one would want to merge code that is not perfect yet, but keeping that in a bug I think would be better. In my experience the best part about the post-commit code review was getting comments on your work, which you then could fix - but now we can do this before even merging the code! :-)
Merlijn
Yes I aggree with pre-commit code review. But there also could be remaining bugs after the code was pushed and identified to that code. Anyway I've additional questions to that gerrit workflow:
1st: Is there any way to download these patches for review purposes and merge it to the working copy. It is very uncomfortable do do that by hand and in some cases it is necessary to test the code snippets and not only read it.
2nd: What is the meaning of the scorings "verified" vs. "Code-Review"
Thanks xqt
On 11 August 2013 12:26, info@gno.de wrote:
Yes I aggree with pre-commit code review. But there also could be remaining bugs after the code was pushed and identified to that code.
Yes, that is true. I think it would be best to have them as bugs, especially after we migrate to bugzilla, which would make linking to bugs/patches easy.
Anyway I've additional questions to that gerrit workflow:
1st: Is there any way to download these patches for review purposes and merge it to the working copy. It is very uncomfortable do do that by hand and in some cases it is necessary to test the code snippets and not only read it.
Using git-review:
git review -d <change number>
which would check out the change. If you need to make any changes, you can do this by editing the files, then
git commit --amend <files> git review
which then will upload a new changeset to gerrit.
I'm not really sure though how you can do this under windows easily, as tortoisegit doesn't seem to have any git-review capabilities...
2nd: What is the meaning of the scorings "verified" vs. "Code-Review"
In our case, "Verified" is used by jenkins-bot to set 'OK' or 'not OK' after pep8 validation (and in the future unit tests). Code-Review is used by the human reviewers as approval. To merge, both have to be 'OK' (+2).
Best, Merlijn
On 11 August 2013 12:48, Merlijn van Deen valhallasw@arctus.nl wrote:
I'm not really sure though how you can do this under windows easily, as tortoisegit doesn't seem to have any git-review capabilities...
http://wiki.typo3.org/Contribution_Walkthrough_with_TortoiseGit seems to
be a guide that explains how to do gerrit with TortoiseGit.
pywikipedia-l@lists.wikimedia.org