Bugs item #1757382, was opened at 2007-07-20 10:44 Message generated for change (Comment added) made by btongminh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1757382...

Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: interwiki Group: None Status: Closed Resolution: Fixed Priority: 5 Private: No Submitted By: DarkoNeko (darkoneko) Assigned to: Nobody/Anonymous (nobody) Summary: edit conflit undetected

Initial Comment: I'm using the freshest version of pywikipediabot (it's certain, as I had to reinstall everything from CVS since my HD crashed a few days ago)

the problem is this diff : http://es.wikipedia.org/w/index.php?title=6_de_febrero&diff=prev&old... the diff taken in account is in fact the previous version, http://es.wikipedia.org/w/index.php?title=6_de_febrero&diff=prev&old...

the time lag of 1hour can be explained by the fact the date page took forever to be analysed, or maybe there was a big bunch of "waiting 5 second because of server lag" too, between the moment it took the page and the moment it wrote it.

But the script didn't detect a change was made to the page in the meanwhile.

----------------------------------------------------------------------

Comment By: Bryan (btongminh) Date: 2007-08-09 18:45

Message: Logged In: YES user_id=1806226 Originator: NO

This fix by Andre Engels causes my bot to always raise an edit conflict on [[:commons:User:CommonsDelinker/commands]]. If I recall correctly, the sand box solution gave you an edit token from your normal username, and not from your sysopname, but I'll check next time before I commit.

----------------------------------------------------------------------

Comment By: SourceForge Robot (sf-robot) Date: 2007-08-09 04:20

Message: Logged In: YES user_id=1312539 Originator: NO

This Tracker item was closed automatically by the system. It was previously set to a Pending status, and the original submitter did not respond within 14 days (the time period specified by the administrator of this Tracker).

----------------------------------------------------------------------

Comment By: Daniel Herding (wikipedian) Date: 2007-07-25 23:37

Message: Logged In: YES user_id=880694 Originator: NO

I tracked this issue and I think it is now fixed in SVN. Please update immediately, and please help testing this solution. Here is my SVN commit message:

Andre Engels did it properly in wikipedia.py CVS r1.927 (SVN r3710) with the description "Avoid 'solving' edit conflicts by throwing away the conflicting edit."

Bryan broke it in wikipedia.py CVS r1.950 (SVN r3837) with the description "Undo the change in r1.927 to get a token of the page itself instead of the sandbox, to prevent edit conflicts when editting as sysop."

I basically reverted it to Andre's version. I didn't test if unwanted edit conflicts are raised when someone edits the sandbox. But even if that's the case, having an edit conflict here and there is better than the catastrophic situation that we have at the moment (bots overwrite other user's changes).

----------------------------------------------------------------------

Comment By: Byrial Ole Jensen (byrial) Date: 2007-07-23 23:21

Message: Logged In: YES user_id=23252 Originator: NO

A new fresh example:

http://en.wikipedia.org/w/index.php?title=2007_FIFA_U-20_World_Cup&diff=... - that edit from 20:29 undid 8 versions made in the previous hour from 19:29 to 20:24.

----------------------------------------------------------------------

Comment By: Byrial Ole Jensen (byrial) Date: 2007-07-20 20:28

Message: Logged In: YES user_id=23252 Originator: NO

I was about to make a similar bug report. Instead I can now give two more examples of undetected edit conflicts: - http://en.wikipedia.org/w/index.php?title=November_7&diff=144478910&... - http://no.wikipedia.org/w/index.php?title=%C3%85rsta_holmar&diff=2437723...

----------------------------------------------------------------------

You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1757382...