Bugs item #1959384, was opened at 2008-05-07 09:56 Message generated for change (Comment added) made by filnik You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1959384...

Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None

Status: Closed

Resolution: None Priority: 5 Private: No Submitted By: DarkoNeko (darkoneko) Assigned to: Nobody/Anonymous (nobody) Summary: welcome.py seems to ignore offset

Initial Comment: Version used: 5318 (latest available, since I did an update just before re-testing the bug)

Command used : /usr/bin/python ~/pywikipedia/welcome.py -nlog -limit:300 -offset:40 -random -time:300

Problem : the script ignores offset and welcomes users since the first one (verified using http://fr.wikipedia.org/wiki/Special:log/newusers )

I thought the problem was "it ignores the 40 first lines, regardless of what action it is" but it's not the case : the welcomed user (Yusukay) was 6th in user creation list, and 27th in the overall log.

----------------------------------------------------------------------

Comment By: Filnik (filnik)

Date: 2008-05-08 13:08

Message: Logged In: YES user_id=1834469 Originator: NO

Yep, I've found this (strange, to say the truth) problem in another script but I remembered just now that there's that problem also on welcome.py. By the way, nicdumz has fixed it perfectly, I wouldn't have done it better :-) Well done ;-)

Filnik

----------------------------------------------------------------------

Comment By: NicDumZ — Nicolas Dumazet (nicdumz) Date: 2008-05-07 14:48

Message: Logged In: YES user_id=1963242 Originator: NO

Actually Mediawiki Special:Log has changed lately.

It's not using anymore a number offset, but a timestamp offset instead.

I fixed this on r5320, now you have to use a yyyymmddhhmmss timestamp as an -offset argument : it will only welcome users OLDER than that time. (Actually this time is server-dependant, it's GMT time for wikimedia projects).

After thinking more about this issue, I also added a timeoffset:# parameter : it will only welcome users older than # minutes.

(These argument names are confusing, offset, timeoffset, and time, but I could not really find better names. If a developer has better names, just go ahead, and *please add a deprecated warning for the old names* )

----------------------------------------------------------------------

You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1959384...