Revision: 6307 Author: multichill Date: 2009-01-28 13:24:18 +0000 (Wed, 28 Jan 2009)
Log Message: ----------- Fix handleArg().
Modified Paths: -------------- trunk/pywikipedia/pagegenerators.py
Modified: trunk/pywikipedia/pagegenerators.py =================================================================== --- trunk/pywikipedia/pagegenerators.py 2009-01-27 20:38:34 UTC (rev 6306) +++ trunk/pywikipedia/pagegenerators.py 2009-01-28 13:24:18 UTC (rev 6307) @@ -1034,7 +1034,7 @@ pass if gen: self.gens.append(gen) - return True + return self.getCombinedGenerator() else: return False
Sorry ?
I don't understand this change: the usage of handleArg() is in replace.py :
if not genFactory.handleArg(arg): commandline_replacements.append(arg)
and it's the only call. We never use the return value of handleArg()
Could you elaborate more what you're doing here multichill?
Thanks =)
2009/1/28 multichill@svn.wikimedia.org:
Revision: 6307 Author: multichill Date: 2009-01-28 13:24:18 +0000 (Wed, 28 Jan 2009)
Log Message:
Fix handleArg().
Modified Paths:
trunk/pywikipedia/pagegenerators.py
Modified: trunk/pywikipedia/pagegenerators.py
--- trunk/pywikipedia/pagegenerators.py 2009-01-27 20:38:34 UTC (rev 6306) +++ trunk/pywikipedia/pagegenerators.py 2009-01-28 13:24:18 UTC (rev 6307) @@ -1034,7 +1034,7 @@ pass if gen: self.gens.append(gen)
return True
return self.getCombinedGenerator() else: return False
Hi Nicolas,
Nicolas Dumazet schreef:
Sorry ?
I don't understand this change: the usage of handleArg() is in replace.py :
if not genFactory.handleArg(arg): commandline_replacements.append(arg)
and it's the only call. We never use the return value of handleArg()
Could you elaborate more what you're doing here multichill?
Of course. The assumption in the big pagegenerators.py change ( http://svn.wikimedia.org/viewvc/pywikipedia?view=rev&revision=6270 ) is that all user programs are part of pywikipedia. This is for backwards compatibility.
Maarten
Thanks =)
pywikipedia-l@lists.wikimedia.org