Modified: trunk/pywikipedia/fixes.py

On Fri, August 22, 2008 11:43 pm, Francesco Cosoleto wrote:

mfarag@svn.wikimedia.org ha scritto:

(...)

...

Restore original comment

(...)

...

 #Corrections for Arabic Wikipedia and any Arabic wiki.

• #python replace.py -always -start:! -fix:correct-ar

• # These spelling corrections are very important for the
• # Arabic Wikipedia. Please don't remove it. The file is
• # shared between all bot operators, so it is in the repository.
• 'correct-ar': {

I am very disappointing to see commits that simply ignore previous comments. I don't think this is a nice use of SVN access.

And to what 'original comment' does this refer? From when? Why was it removed? Help, INFO! That's what the svn log field is for!

Thanks to svn blame, it's fairly easy to create a timeline

Timeline: * pre-january, the text was (linebreaks removed) "Corrections for Arabic Wikipedia And any Arabic wiki. python replace.py -always -start:! -fix:correct-ar" * 14 january, wikipedian added "It isn't fully clear what it's supposed to do, if is safe or correct (included for more ancient arabic text). As now it's possible use user-fixes.py and if no objections or explanations is given, this part of code might be removed." and removed the replace.py instruction * 24 july, alnokta changed this into "These spelling corrections are very important for the Arabic Wikipedia. Please don't remove it. The file is shared between all bot operators, so it is in the repository." * 22 august, mfarag removes this text and re-instates the replace.py instruction.

So it seems the removal was actually reasonable... which does not follow from the log message nor the diff. Please enter extensive information into the log field: people actually read it, and want to know what happened. Something like 'Re-added fixed.py instruction and removed old (24 july) discussion on correctness of this section' would have been much more informative and would probably not have prevoked a fierce reaction by Francesco ;)

--Merlijn