nicdumz@svn.wikimedia.org ha scritto:
- def resolvemagicwords(self, wikitext):
"""Replace the {{ns:xx}} marks in a wikitext with the namespace names"""
defaults = []
for namespace in self.family.namespaces.itervalues():
value = namespace.get('_default', None)
if value:
if isinstance(value, list):
defaults += value
else:
defaults.append(value)
I don't write comments about SVN commits anymore because I am tired of getting ignored and of people that doesn't read the mailing-list (and not only) and have commit access. I have major open source projects for wasting my time.
2009/6/25 Francesco Cosoleto cosoleto@gmail.com:
I don't write comments about SVN commits anymore because I am tired of getting ignored and of people that doesn't read the mailing-list (and not only) and have commit access. I have major open source projects for wasting my time.
Have I ever ignored a comment from you that was directly addressed to me? I don't think so.
Anyway, what's wrong with my commit? I don't really see the issue here.
* Some people don't reply to your comments because they are not comfortable enough in English to do so. I can understand them. * Some people don't reply to your comments because of the tone you use. Indeed, there are times where you could have been more pedagogic. I can understand them.
I personally don't see how emitting remarks is a loss of time. The more we are... the better we should perform.
As a generic remark, I think that you could probably help more here, if you were committing the changes you were suggesting: after a few days, if the original committer does not commit back fixing the problems you mentioned, you should grad your keyboard, and fixityourself(). My opinion is that the more people see your code cleanup/standardization efforts, the more they will be sensible to your remarks, and the more they will pay attention to generic guidelines before pushing new code. But of course, it's only my own POV.
But sure, if you feel like you're wasting your time, please invest your time elsewhere. Open Source is "for fun"; if you don't enjoy being around anymore, please try to use your talents in another community, there's no point in sticking around in a frustrated manner :)
Nicolas Dumazet ha scritto:
Have I ever ignored a comment from you that was directly addressed to me? I don't think so.
No, I was speaking in general. I have no problems with you.
Anyway, what's wrong with my commit? I don't really see the issue here.
I don't want contradict my latest statements.
- Some people don't reply to your comments because they are not
comfortable enough in English to do so. I can understand them.
- Some people don't reply to your comments because of the tone you
use. Indeed, there are times where you could have been more pedagogic. I can understand them.
Nooo... Those aren't good reasons for not writing nothing. It's just to be polite. I think you are wrong about latter point and it isn't my purpose be rude.
I personally don't see how emitting remarks is a loss of time. The more we are... the better we should perform.
As a generic remark, I think that you could probably help more here, if you were committing the changes you were suggesting: after a few days, if the original committer does not commit back fixing the problems you mentioned, you should grad your keyboard, and fixityourself(). My opinion is that the more people see your code
That shouldn't be the rule. No one reads or takes care, no one undestands that he should fix the code your self.
I repeat: I don't comment anymore SVN commits in mailing-list. Sorry for showing to you my disappointed, I could spare it.
pywikipedia-l@lists.wikimedia.org