Bugs item #1896539, was opened at 2008-02-19 02:01 Message generated for change (Comment added) made by rotemliss You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1896539...
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None
Status: Closed Resolution: Fixed
Priority: 5 Private: No Submitted By: NicDumZ — Nicolas Dumazet (nicdumz) Assigned to: Nobody/Anonymous (nobody) Summary: Site class is missing the documented "messages" method
Initial Comment: Strange that no one noticed that. I was using Site.messages field without noticing that I should expect a method. Until the recent rewrite, it was working properly, but as of now, Site.messages is not initialized properly and accessing it is hazardous. I'd like messages() implemented, please :)
Thanks !
----------------------------------------------------------------------
Comment By: Rotem Liss (rotemliss)
Date: 2008-02-19 18:29
Message: Logged In: YES user_id=1327030 Originator: NO
Added method and removed duplicate code (noted in comment) in r5053.
----------------------------------------------------------------------
Comment By: NicDumZ — Nicolas Dumazet (nicdumz) Date: 2008-02-19 02:08
Message: Logged In: YES user_id=1963242 Originator: YES
_getEditPage is setting the Site.messages field, which is not accessed within the Site class :
#Check for new messages if '<div class="usermessage">' in text: self.site().messages=True else: self.site().messages=False
the _messages array should be used instead.
----------------------------------------------------------------------
You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1896539...
pywikipedia-l@lists.wikimedia.org