※ 引述《"Francesco Cosoleto" <cosoleto(a)gmail.xn--com>:-5o3gk48x0sbk8mlj0be09m
First of all, you, Alex, should try to resolve pending
problems about
your previous commits. Anyway...
alexsh(a)svn.wikimedia.org ha scritto:
Revision: 6950
Author: alexsh
Date: 2009-06-11 16:46:35 +0000 (Thu, 11 Jun 2009)
Log Message:
-----------
Fix:cannot locate password files if running script in subfolder
"login.py: Open password file even if the script haven't run from base
directory"?
It is running from "current directory" in the command console,
and I found this when I cleanout old login data and run maintenance\readtalk.py.
And I just revert login.py and run in sub folder (using "..\login.py"),
it cannot locate passfile, too.
[...]
Log Message:
-----------
Typo: cannot use double slash in unix...XDrz
...And what "XDrz" stand for?
Nothing...it just a emoticon with XD and Orz..I always using.
3 consecutive commits for a bugfix aren't so much
good.
Proper procedure should be this (for non-trivial changes or files
created by you self, common-sense based):
1. Post patch in mailing-list (I prefer here instead of using the stupid
patch tracker).
A message like:
Subject: [PATCH] Descriptive title
Optional long description or commit message
[patch attached]
2. Wait for comments
3. If changes are required, post again a new patch
4. See 2, then commit.
Well, I think you're right, some bugfix need to test and
proof it before commit to svn.
--
Francesco Cosoleto