Hi Daniel.
It must be my blue eyes and blond hair, but how exactly is it now possible to run replace.py on all pages containing a particular url as reported by Special:Linksearch? I only see a reference to spamremove.py in your reply and there are currently no references to `linksearch`, or ´LinksearchGenerator´ in replace.py other than in the top if the file (documentation)...
Cheers!
Siebrand
-----Oorspronkelijk bericht----- Van: pywikipedia-l-bounces@lists.wikimedia.org [mailto:pywikipedia-l-bounces@lists.wikimedia.org] Namens Daniel Herding Verzonden: maandag 6 augustus 2007 12:07 Aan: pywikipedia-l@lists.wikimedia.org Onderwerp: Re: [Pywikipedia-l] SVN: [3964] trunk/pywikipedia
On Sunday 05 August 2007 16:14:48 siebrand@svn.wikimedia.org wrote:
*Added -linksearch in replace.py (submitted by Filnik)
Siebrand: replace.py already had this functionality, with the parameter -weblink. Thus, I have reverted your change.
Andre: neither Misza nor I have worked on this. I just threw out one of the two linksearch_address() methods from family.py, but both my pagegenerators.LinksearchGenerator and your wikipedia.Site.linksearch() are still there. Could you try and fix the code duplication?
The following is the mailing list correspondence regarding this issue:
----
Subject: Re: [pyWikipediaBot-users] pywikipedia spamremove.py, NONE, 1.1 family.py, 1.256, 1.257 wikipedia.py, 1.958, 1.959 Date: Donnerstag 19 Juli 2007 From: "Andre Engels" <andreengels@gm...> To: "Daniel Herding" <DHerding@gm...>
2007/7/19, Daniel Herding <DHerding@gm...>:
Hi Andre,
I think you missed that we already had got code for external link search (Special:Linksearch). It is in pagegenerators.py and has been added by Misza13 in March. If you want to test it, run this:
python pagegenerators.py -weblink:http://www.ebay.com
(currently it won't work because of a method name conflict, see below.)
We now have some code duplication, for example we have two methods called linksearch_address() in family.py. I'm not sure which code is the better
one.
Misza's method can browse through several pages if there is more than one page full of results, but your method has some wildcard handling.
Maybe you and Misza can clean this up together, you know best what the requirements are. Afterwards, I'd like to refactor spamremove.py a bit if
you
don't mind, it sounds quite useful.
Well, I would be willing to combine the two, but I'm going to be on holiday for 10 days from tomorrow, so I don't currently have the time. If you or Misza or anyone else wants to do it in the meantime, I'd be happy about it too. If not, send me a reminder when I'm back (basically, first week of August)
_______________________________________________ Pywikipedia-l mailing list Pywikipedia-l@lists.wikimedia.org http://lists.wikimedia.org/mailman/listinfo/pywikipedia-l