On 16 June 2014 16:33, John phoenixoverride@gmail.com wrote:
Avoiding the headache of re-inventing the wheel across dozens of scripts that use that code?
There is only one use of Page.protect() , even in compat, so IMO that code should mostly be moved from Page to scripts/protect.py.
There is also only one use of Page.delete(mark=True), so IMO that code should mostly be moved from Page to scripts/category.py.
There are many more uses of Page.delete() prompt=True, especially in compat, so I can see the need for re-use here.
On Mon, Jun 16, 2014 at 10:11 PM, Merlijn van Deen valhallasw@arctus.nl wrote:
Then it should be in the default 'bot' class, not in the Page class.
I like that approach. I'll work on it after my other Bot changeset is checked in.
https://gerrit.wikimedia.org/r/#/c/139309/