Pywikipedia-l August 2013

pywikipedia-l@lists.wikimedia.org

21 participants
36 discussions

Re: [Pywikipedia-l] Code review in gerrit
by info＠gno.de 11 Aug '13

11 Aug '13

----- Original Nachricht ---- Von: Merlijn van Deen <valhallasw(a)arctus.nl> An: Pywikipedia discussion list <pywikipedia-l(a)lists.wikimedia.org> Datum: 10.08.2013 16:13 Betreff: Re: [Pywikipedia-l] Code review in gerrit > On 2 August 2013 08:52, <info(a)gno.de> wrote: > > > Ok (or to bad). I am just for a tool stuff reminder for "this part of > code > > has still remaining bugs" (fixme) and when it is solved mark it as > solved. > > I assume we must use the bug tracker for that which is not very > comfortable > > (at least of the last changes at sf ihmo). > > > > I think the basic workflow would be to fix those bugs before merging the > code. Of course, it could be possible one would want to merge code that is > not perfect yet, but keeping that in a bug I think would be better. In my > experience the best part about the post-commit code review was getting > comments on your work, which you then could fix - but now we can do this > before even merging the code! :-) > > Merlijn > Yes I aggree with pre-commit code review. But there also could be remaining bugs after the code was pushed and identified to that code. Anyway I've additional questions to that gerrit workflow: 1st: Is there any way to download these patches for review purposes and merge it to the working copy. It is very uncomfortable do do that by hand and in some cases it is necessary to test the code snippets and not only read it. 2nd: What is the meaning of the scorings "verified" vs. "Code-Review" Thanks xqt

2 2

SVN2GIT
by Dr. Trigon 10 Aug '13

10 Aug '13

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello Merlijn I heard something about your experiments with a SVN2GIT tool or solution? May I ask what the status there? What about that? Thanks and Greetings DrTrigon -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlIGHwgACgkQAXWvBxzBrDCwigCfVi9zsUA2mrexLK8hnMs0jRmC YuwAn3dXkYJttCNn3R1loGvnZRbs+dHs =esVt -----END PGP SIGNATURE-----

2 1

Code review in gerrit
by info＠gno.de 10 Aug '13

10 Aug '13

Hi folks, is there any posibility reviewing code _after_ it has been merged as it was before we went to git/gerrit like the mw cr special page. Or us the bug tracker the only remaining way to do it? Greetings xqt

4 4

[Rewrite] Cannot download http://gl.wiktionary.org/wiki/𐌰𐌽𐌳𐌰𐌿𐍂𐌰
by Adrián Chaves Fernández 10 Aug '13

10 Aug '13

I have written the following script: # -*- coding: utf-8 -*- import pywikibot site = pywikibot.Site("gl", "wiktionary") page = pywikibot.Page(site, u"𐌰𐌽𐌳𐌰𐌿𐍂𐌰") print page.get() It fails with the following output: [gallaecio@afonso fontes]$ python2 test.py Traceback (most recent call last): File "test.py", line 7, in <module> print page.get() File "/usr/lib/python2.7/site-packages/pywikibot/__init__.py", line 249, in wrapper return method(*__args, **__kw) File "/usr/lib/python2.7/site-packages/pywikibot/__init__.py", line 249, in wrapper return method(*__args, **__kw) File "/usr/lib/python2.7/site-packages/pywikibot/page.py", line 278, in get self._getInternals(sysop) File "/usr/lib/python2.7/site-packages/pywikibot/page.py", line 302, in _getInternals self.site.loadrevisions(self, getText=True, sysop=sysop) File "/usr/lib/python2.7/site-packages/pywikibot/page.py", line 96, in site return self._link.site File "/usr/lib/python2.7/site-packages/pywikibot/page.py", line 3080, in site self.parse() File "/usr/lib/python2.7/site-packages/pywikibot/page.py", line 3037, in parse u"contains illegal char(s) '%s'" % m.group(0)) pywikibot.exceptions.InvalidTitle: contains illegal char(s) '𐌰'

3 3

xmlreader.py
by Automatik Wikipedia 10 Aug '13

10 Aug '13

Hi, I saw the existence of this script, and I would like have some informations about the parameters to use it. Does someone know it? I saw for instance the parameter allrevisions, but is there a parameter to choose the page where we put the reults the page than match the content)? Parameter for the regexp? Thanks by advance for your answer

2 1

Regex question
by Bináris 10 Aug '13

10 Aug '13

Hi, \b in a regex treats letter "é" (which is a correct Hungarian letter) as a word boundary. Can I prevent this behaviour with some kind of settings? -- Bináris

3 2

Extending replace.py with an option to work on page titles instead of page content
by Adrián Chaves Fernández 10 Aug '13

10 Aug '13

I would like to know two things: • I want to implement a script to rename pages. Do you agree that implementing this feature within replace.py as an option would the the right approach, or should I create a separated script? • What is the current procedure to provide patches (for the rewrite branch)? Reading http://www.mediawiki.org/wiki/Manual:Pywikipediabot/Development didn’t solve this doubt of mine. I see there is a Patches section in SourceForge, is that the right place?

3 2

wrongly defined coordinate datatype in wikidata
by Tomasz Magulski 06 Aug '13

06 Aug '13

Hi, I've found yesterday, that there are some wrongly defined instances of coordinate datatype in wikidata. For reference check [1]. I guess PWB works properly, but we should be more tolerant right now. For me I've found some workaround: diff --git a/pywikibot/__init__.py b/pywikibot/__init__.py index 12bf9ec..b2044c9 100644 --- a/pywikibot/__init__.py +++ b/pywikibot/__init__.py @@ -163,10 +163,8 @@ class Coordinate(object): globes = {} for k in site.globes(): globes[site.globes()[k]] = k - - globekey = data['globe'] - if globekey: - # FIXME: Should probably use get() with some error handling when it + globes[k] = k + if 'globe' in data: globe = globes[data['globe']] else: # Default to earth or should we use None here? cheers! [1] https://www.wikidata.org/wiki/Wikidata:Project_chat#Coordinate_Datatype_mis… -- Tomasz Magulski

1 0

git migration
by info＠gno.de 04 Aug '13

04 Aug '13

It seems SVN is not closed for submitting and i18n-bot does not push to git [1] [1] http://www.mediawiki.org/wiki/Special:Code/pywikipedia/11781 Best xqt

1 0

SVN access
by Hazard-SJ 04 Aug '13

04 Aug '13

Hello, I am again asking if it is possible for me to gain SVN access (I know it probably wouldn't last too long, considering that SVN will be read-only in the (near?) future, but that time is still unknown to us). I frequently use the framework, and I'd like to be able to directly make commits, rather than generating patches to put on the bug tracker, when possible. This would include things such as PEP and typo fixes, as well as improving wikipedia.DataPage. Thanks. Hazard-SJ

7 15

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

Pywikipedia-l August 2013