Pywikipediabot now has code review in the same way as MediaWiki[1]. Tim has implemented this a few hours ago. Thanks Tim!
Below you can find a description of the new functionality. I hope we can discuss whatever you may see differently or whatever I may have left out.
Please mind the following if you wish to participate in the code review:
* anyone can use the tool in a read-only mode (right: codereview-use)
* registered users can submit comments on revisions (right: codereview-post-comment)
* coders can link committers to mediawiki.org user accounts. All committers should have an account on mediawiki.org with a confirmed e-mail address and linked their user to their committer identity[2]. This allows you to get e-mails on your revs and follow-up revs. (right: codereview-link-user, role: coder)
* coders can add and remove tags for revisions in the review module. For MediaWiki this feature isn't used that much, but it can be used to group revisions (rights: codereview-add-tag, codereview-remove-tag, role: coder)
* coders can change the status of revisions (right: codereview-set-status, role coder). Possible states are:
** new: default state
** fixme: something needs to be done for this revision is broken - the original committer should feel responsible for doing this
** reverted: this revision has been reverted
** resolved: this revision was marked fixme, but the issue has been resolved in a later revision
** ok: this revision has been reviewed by a coder able to assess the revision and no issues have been found
** verified: uncertain, as not used in MediaWiki code review. I propose not to use this tag until we need it for whatever
* coders can add new coders[3] (role: coder). This is supposed to be a web of trust. Only change state to ok for revisions that you really understand, and keep comments to the point. If you have the coder role, you can do code review also on MediaWiki; please only stick to the project you develop on with regards to code review functionality.
If you make follow-up revisions, please mention to which revision (with r#####) you are following up to in your commit summary. This will automatically link the new revision in the code review page of the followed-up revision.
[1] http://www.mediawiki.org/wiki/Special:Code/pywikipedia
[2] link "(link?)" on http://www.mediawiki.org/wiki/Special:Code/pywikipedia/author/committername
[3] http://www.mediawiki.org/wiki/Special:UserRights/username
[4] list of coders: http://www.mediawiki.org/wiki/Special:ListUsers/coder
Cheers!
Siebrand
From: "Russel Blau" <russblau(a)imapmail.org>:
>> My favorite would be to use @property on both, but it's one more step
>> against backward compatibility.
>
>That would be my favorite, too, but I didn't do it for the very reason you
>suggest.
>
>> PS: I can work on a patch for this upon request, if needed.
>
>I'll take you up on that offer. :-)
>
>Russ
So, after some time spent checking that eveything (hopefully) works correctly,
I've uploaded the patch on sourceforge's tracker[1]. This is quite a huge one,
but as long as my tests were complete, it seems ok.
stan.
[1] https://sourceforge.net/tracker/?func=detail&aid=3010404&group_id=93107&ati…