Pywikipedia-l February 2009

pywikipedia-l@lists.wikimedia.org

22 participants
230 discussions

by russblau＠svn.wikimedia.org

Revision: 6415 Author: russblau Date: 2009-02-22 20:15:45 +0000 (Sun, 22 Feb 2009) Log Message: ----------- fix one of a zillion Windows quirks Modified Paths: -------------- branches/rewrite/pywikibot/bot.py branches/rewrite/pywikibot/pagegenerators.py Modified: branches/rewrite/pywikibot/bot.py =================================================================== --- branches/rewrite/pywikibot/bot.py 2009-02-22 18:12:08 UTC (rev 6414) +++ branches/rewrite/pywikibot/bot.py 2009-02-22 20:15:45 UTC (rev 6415) @@ -291,9 +291,9 @@ def _decodeArg(arg): if sys.platform=='win32': - if config.console_encoding == 'cp850': + if config.console_encoding in ("cp437", 'cp850'): # Western Windows versions give parameters encoded as windows-1252 - # even though the console encoding is cp850. + # even though the console encoding is cp850 or cp437. return unicode(arg, 'windows-1252') elif config.console_encoding == 'cp852': # Central/Eastern European Windows versions give parameters encoded Modified: branches/rewrite/pywikibot/pagegenerators.py =================================================================== --- branches/rewrite/pywikibot/pagegenerators.py 2009-02-22 18:12:08 UTC (rev 6414) +++ branches/rewrite/pywikibot/pagegenerators.py 2009-02-22 20:15:45 UTC (rev 6415) @@ -605,10 +605,10 @@ def DuplicateFilterPageGenerator(generator): """Yield all unique pages from another generator, omitting duplicates.""" - seenPages = {} + seenPages = set([]) for page in generator: if page not in seenPages: - seenPages[page] = None + seenPages.add(page) yield page @@ -946,11 +946,11 @@ yield pywikibot.Page(pywikibot.Link(fd(month, day), site)) -if __name__ == "__main__": +def main(*args): try: gen = None genFactory = GeneratorFactory() - for arg in pywikibot.handleArgs(): + for arg in pywikibot.handleArgs(*args): genFactory.handleArg(arg) gen = genFactory.getCombinedGenerator() if gen: @@ -958,5 +958,11 @@ pywikibot.output(page.title(), toStdout = True) else: pywikibot.showHelp() + except Exception: + pywikibot.logging.exception("") finally: pywikibot.stopme() + + +if __name__=="__main__": + main()

15 years, 2 months

SVN: [6414] trunk/pywikipedia/checkimages.py

by filnik＠svn.wikimedia.org

Revision: 6414 Author: filnik Date: 2009-02-22 18:12:08 +0000 (Sun, 22 Feb 2009) Log Message: ----------- Bugfix for the report, otherwise it's impossible to strike the already seen images Modified Paths: -------------- trunk/pywikipedia/checkimages.py Modified: trunk/pywikipedia/checkimages.py =================================================================== --- trunk/pywikipedia/checkimages.py 2009-02-22 16:21:11 UTC (rev 6413) +++ trunk/pywikipedia/checkimages.py 2009-02-22 18:12:08 UTC (rev 6414) @@ -799,7 +799,7 @@ """ Checking if the file is on commons """ wikipedia.output(u'Checking if %s is on commons...' % self.imageName) commons_site = wikipedia.getSite('commons', 'commons') - regexOnCommons = r"\n\*\[\[:File:%s\]\] is also on '''Commons''': \[\[commons:File:.*?\]\](?: $same name$|)$" % re.escape(self.imageName) + regexOnCommons = r"\[\[:File:%s\]\] is also on '''Commons''': \[\[commons:File:.*?\]\](?: $same name$|)$" % re.escape(self.imageName) hash_found = self.image.getHash() if hash_found == None: return False # Problems? Yes! Image deleted, no hash found. Skip the image. @@ -841,7 +841,7 @@ dupTalkText = wikipedia.translate(self.site, duplicates_user_talk_text) dupComment_talk = wikipedia.translate(self.site, duplicates_comment_talk) dupComment_image = wikipedia.translate(self.site, duplicates_comment_image) - duplicateRegex = r'\n\*(?:\[\[:File:%s\]\] has the following duplicates(?: $\'\'\'forced mode\'\'\'$|):|\*\[\[:File:%s\]\])$' % (re.escape(self.convert_to_url(self.imageName)), re.escape(self.convert_to_url(self.imageName))) + duplicateRegex = r'(?:\[\[:File:%s\]\] has the following duplicates(?: $\'\'\'forced mode\'\'\'$|):|\*\[\[:File:%s\]\])$' % (re.escape(self.convert_to_url(self.imageName)), re.escape(self.convert_to_url(self.imageName))) imagePage = wikipedia.ImagePage(self.site, u'File:%s' % self.imageName) hash_found = imagePage.getHash() duplicates = self.site.getFilesFromAnHash(hash_found)

15 years, 2 months

[ pywikipediabot-Bugs-2627537 ] Missing #REDIRECT localisation for pdc- and de-wiki

by SourceForge.net

Bugs item #2627537, was opened at 2009-02-22 13:01 Message generated for change (Comment added) made by nicdumz You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2627537&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) Assigned to: Nobody/Anonymous (nobody) Summary: Missing #REDIRECT localisation for pdc- and de-wiki Initial Comment: There is no localisation for the pdc-wiki in the actual family.py yet but there should be a new line as follows: redirect = { 'de': [u'WEITERLEITUNG'] 'pdc': [u'WEITERLEITUNG'] but 'REDIRECT' should also allowed see [[w:de:Wikipedia:Weiterleitung]] and http://pdc.wikipedia.org/w/index.php?title=Kallitsch&action=edit <w:de:User:Xqt> ---------------------------------------------------------------------- >Comment By: NicDumZ — Nicolas Dumazet (nicdumz) Date: 2009-02-22 17:23 Message: Fixed in r6413 ("if you don't fix this, we, on dewiki, are going to block all bots". Whatever =p ) ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2009-02-22 16:02 Message: Please also for 'als'-wiki. Otherwise Bots wouln't recognize it as redirect page. <w:de:user:Xqt> ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2627537&group_…

15 years, 2 months

SVN: [6413] trunk/pywikipedia/family.py

by nicdumz＠svn.wikimedia.org

Revision: 6413 Author: nicdumz Date: 2009-02-22 16:21:11 +0000 (Sun, 22 Feb 2009) Log Message: ----------- [ 2627537 ] Missing #REDIRECT localisation for pdc- and de-wiki : Adding [u'WEITERLEITUNG', u'REDIRECT'] for de: and pdc: Modified Paths: -------------- trunk/pywikipedia/family.py Modified: trunk/pywikipedia/family.py =================================================================== --- trunk/pywikipedia/family.py 2009-02-22 16:13:01 UTC (rev 6412) +++ trunk/pywikipedia/family.py 2009-02-22 16:21:11 UTC (rev 6413) @@ -3204,6 +3204,7 @@ 'cs': [u'PŘESMĚRUJ'], 'cu': [u'ПРѢНАПРАВЛЄНИѤ'], 'cy': [u'ail-cyfeirio', u'ailgyfeirio'], + 'de': [u'WEITERLEITUNG', u'REDIRECT'], 'el': [u'ΑΝΑΚΑΤΕΥΘΥΝΣΗ'], 'eo': [u'ALIDIREKTU'], 'es': [u'REDIRECCIÓN'], @@ -3241,6 +3242,7 @@ 'nl': [u'DOORVERWIJZING'], 'nn': [u'omdiriger'], 'oc': [u'REDIRECCION'], + 'pdc': [u'WEITERLEITUNG', u'REDIRECT'], 'pl': [u'REDIRECT', u'TAM', u'PRZEKIERUJ'], 'ro': [u'REDIRECTEAZA'], 'ru': [u'REDIRECT', u'перенаправление', u'перенапр'],

15 years, 2 months

[ pywikipediabot-Bugs-2485193 ] replace.py: Patch: Ignore variations in newlines on new/old

by SourceForge.net

Bugs item #2485193, was opened at 2009-01-04 10:58 Message generated for change (Comment added) made by nicdumz You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2485193&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: other Group: None >Status: Open >Resolution: Rejected Priority: 5 Private: No Submitted By: Murph (pauljmurph) Assigned to: Nobody/Anonymous (nobody) Summary: replace.py: Patch: Ignore variations in newlines on new/old Initial Comment: Pywikipedia [http] trunk/pywikipedia (r6219, Jan 03 2009, 14:34:49) Python 2.5.1 (r251:54863, Jan 17 2008, 19:35:17) [GCC 4.0.1 (Apple Inc. build 5465)] The standard replace.py has a habit of showing a file as having changed, but with zero changes if a \r\n has been changed to \n by one of the patterns. Solution: treat \r\n as \n in the comparison to determine if any changes have been made. Patch attached. ---------------------------------------------------------------------- >Comment By: NicDumZ — Nicolas Dumazet (nicdumz) Date: 2009-02-22 17:15 Message: Reverted in r6412. While I understand the issue here, the patch was not the right solution. strip()-ing the text gives unwanted behavior: let's say you wanted to do changes such as "^\r\n" "" ! Well, with that patch, that wasn't possible anymore. Maybe you could help us giving a special test case where the output is annoying, so we can fix properly the issue? Replace.py is one of the most used scripts here, having the best possible behavior matters to us. ---------------------------------------------------------------------- Comment By: siebrand (siebrand) Date: 2009-01-27 09:45 Message: Applied in r6296. Thanks. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2485193&group_…

15 years, 2 months

SVN: [6412] trunk/pywikipedia/replace.py

by nicdumz＠svn.wikimedia.org

Revision: 6412 Author: nicdumz Date: 2009-02-22 16:13:01 +0000 (Sun, 22 Feb 2009) Log Message: ----------- Reverting r6296 http://svn.wikimedia.org/viewvc/pywikipedia?view=rev&revision=6296 Since that revision, changes like "^\r\n" "" to remove leading newlines did not work anymore. Modified Paths: -------------- trunk/pywikipedia/replace.py Modified: trunk/pywikipedia/replace.py =================================================================== --- trunk/pywikipedia/replace.py 2009-02-22 14:36:55 UTC (rev 6411) +++ trunk/pywikipedia/replace.py 2009-02-22 16:13:01 UTC (rev 6412) @@ -371,7 +371,7 @@ % page.aslink()) break new_text = self.doReplacements(new_text) - if new_text.strip().replace('\r\n', '\n') == original_text.strip().replace('\r\n', '\n'): + if new_text == original_text: wikipedia.output('No changes were necessary in %s' % page.aslink()) break

15 years, 2 months

[ pywikipediabot-Bugs-2627985 ] disambig in haw.wikipedia

by SourceForge.net

Bugs item #2627985, was opened at 2009-02-22 16:20 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2627985&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: interwiki Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Carsrac (carsrac) Assigned to: Nobody/Anonymous (nobody) Summary: disambig in haw.wikipedia Initial Comment: {{Anakuhi:Huaʻōlelo puana like}} is the haw translation of {{template:disambig}} ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2627985&group_…

15 years, 2 months

[ pywikipediabot-Bugs-2627537 ] Missing #REDIRECT localisation for pdc- and de-wiki

by SourceForge.net

Bugs item #2627537, was opened at 2009-02-22 12:01 Message generated for change (Comment added) made by nobody You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2627537&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) Assigned to: Nobody/Anonymous (nobody) Summary: Missing #REDIRECT localisation for pdc- and de-wiki Initial Comment: There is no localisation for the pdc-wiki in the actual family.py yet but there should be a new line as follows: redirect = { 'de': [u'WEITERLEITUNG'] 'pdc': [u'WEITERLEITUNG'] but 'REDIRECT' should also allowed see [[w:de:Wikipedia:Weiterleitung]] and http://pdc.wikipedia.org/w/index.php?title=Kallitsch&action=edit <w:de:User:Xqt> ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2009-02-22 15:02 Message: Please also for 'als'-wiki. Otherwise Bots wouln't recognize it as redirect page. <w:de:user:Xqt> ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2627537&group_…

15 years, 2 months

SVN: [6411] trunk/pywikipedia/catlib.py

by filnik＠svn.wikimedia.org

Revision: 6411 Author: filnik Date: 2009-02-22 14:36:55 +0000 (Sun, 22 Feb 2009) Log Message: ----------- bugfix.. another.. Modified Paths: -------------- trunk/pywikipedia/catlib.py Modified: trunk/pywikipedia/catlib.py =================================================================== --- trunk/pywikipedia/catlib.py 2009-02-22 12:31:24 UTC (rev 6410) +++ trunk/pywikipedia/catlib.py 2009-02-22 14:36:55 UTC (rev 6411) @@ -540,7 +540,7 @@ except KeyError: if int(cmlimit) != 500: wikipedia.output(u'An Error occured, trying to reload the category.') - return categoryAllElements(CatName, cmlimit = 500) + return categoryAllElementsAPI(CatName, cmlimit = 500) else: raise wikipedia.Error(data) if len(members) == int(cmlimit): @@ -554,7 +554,7 @@ if ns == 14: if title not in categories_parsed: categories_parsed.append(title) - (results_part, categories_parsed) = categoryAllElements(title, 5000, categories_parsed) + (results_part, categories_parsed) = categoryAllElementsAPI(title, 5000, categories_parsed) allmembers.extend(results_part) for member in allmembers: ns = member['ns']

15 years, 2 months

SVN: [6410] branches/rewrite/pywikibot

by nicdumz＠svn.wikimedia.org

Revision: 6410 Author: nicdumz Date: 2009-02-22 12:31:24 +0000 (Sun, 22 Feb 2009) Log Message: ----------- Introducing pywikibot.deprecated() to handle easily deprecation warnings Modified Paths: -------------- branches/rewrite/pywikibot/__init__.py branches/rewrite/pywikibot/page.py branches/rewrite/pywikibot/site.py Modified: branches/rewrite/pywikibot/__init__.py =================================================================== --- branches/rewrite/pywikibot/__init__.py 2009-02-22 11:32:12 UTC (rev 6409) +++ branches/rewrite/pywikibot/__init__.py 2009-02-22 12:31:24 UTC (rev 6410) @@ -22,6 +22,22 @@ logging.basicConfig(fmt="%(message)s") +def deprecated(instead=None): + """Outputs a method deprecation warning. + Uses the stack to determine class and name of calling method + + @param instead: if provided, will be used to specify the replacement + @type instead: string + """ + f = sys._getframe(1) + classname = f.f_locals['self'].__class__.__name__ + funcname = f.f_code.co_name + if new: + logging.warning("%s.%s is DEPRECATED, use %s instead" % \ + (classname, funcname, instead)) + else: + logging.warning("%s.%s is DEPRECATED." % (classname, funcname)) + def deprecate_arg(old_arg, new_arg): """Decorator to declare old_arg deprecated and replace it with new_arg""" logger = logging.getLogger() Modified: branches/rewrite/pywikibot/page.py =================================================================== --- branches/rewrite/pywikibot/page.py 2009-02-22 11:32:12 UTC (rev 6409) +++ branches/rewrite/pywikibot/page.py 2009-02-22 12:31:24 UTC (rev 6410) @@ -11,6 +11,7 @@ import pywikibot from pywikibot import deprecate_arg +from pywikibot import deprecated from pywikibot import config import pywikibot.site @@ -1172,28 +1173,28 @@ def encoding(self): """DEPRECATED: use Site.encoding() instead""" - logger.debug(u"Page.encoding() is deprecated; use Site.encoding().") + deprecated("Site.encoding()") return self.site().encoding() def titleWithoutNamespace(self, underscore=False): """DEPRECATED: use self.title(withNamespace=False) instead.""" - logger.debug(u"Page.titleWithoutNamespace() method is deprecated.") + deprecated("Page.title(withNamespace=False)") return self.title(underscore=underscore, withNamespace=False, withSection=False) def titleForFilename(self): """DEPRECATED: use self.title(as_filename=True) instead.""" - logger.debug(u"Page.titleForFilename() method is deprecated.") + deprecated("Page.title(as_filename=True)") return self.title(as_filename=True) def sectionFreeTitle(self, underscore=False): """DEPRECATED: use self.title(withSection=False) instead.""" - logger.debug(u"Page.sectionFreeTitle() method is deprecated.") + deprecated("Page.title(withSection=False)") return self.title(underscore=underscore, withSection=False) def aslink(self, forceInterwiki=False, textlink=False, noInterwiki=False): """DEPRECATED: use self.title(asLink=True) instead.""" - logger.debug(u"Page.aslink() method is deprecated.") + deprecated("Page.title(asLink=True)") return self.title(asLink=True, forceInterwiki=forceInterwiki, allowInterwiki=not noInterwiki, textlink=textlink) @@ -1203,7 +1204,7 @@ DEPRECATED: use self.title(asUrl=True) instead. """ - logger.debug(u"Page.urlname() method is deprecated.") + deprecated("Page.title(asUrl=True)") return self.title(asUrl=True) ####### DISABLED METHODS (warnings provided) ###### @@ -1212,14 +1213,12 @@ def removeImage(self, image, put=False, summary=None, safe=True): """Old method to remove all instances of an image from page.""" - pywikibot.output(u"Page.removeImage() is no longer supported.", - level=pywikibot.WARNING) + logger.warning(u"Page.removeImage() is no longer supported.") def replaceImage(self, image, replacement=None, put=False, summary=None, safe=True): """Old method to replace all instances of an image with another.""" - pywikibot.output(u"Page.replaceImage() is no longer supported.", - level=pywikibot.WARNING) + logger.warning(u"Page.replaceImage() is no longer supported.") class ImagePage(Page): @@ -1282,8 +1281,7 @@ def getFileMd5Sum(self): """Return image file's MD5 checksum.""" - logger.debug( - u"ImagePage.getFileMd5Sum() is deprecated; use getFileSHA1Sum().") + deprecated("ImagePage.getFileSHA1Sum()") # FIXME: MD5 might be performed on incomplete file due to server disconnection # (see bug #1795683). import md5, urllib @@ -1496,22 +1494,22 @@ #### DEPRECATED METHODS #### def subcategoriesList(self, recurse=False): """DEPRECATED: Equivalent to list(self.subcategories(...))""" - logger.debug(u"Category.subcategoriesList() method is deprecated.") + deprecated("list(Category.subcategories(...))") return sorted(list(set(self.subcategories(recurse)))) def articlesList(self, recurse=False): """DEPRECATED: equivalent to list(self.articles(...))""" - logger.debug(u"Category.articlesList() method is deprecated.") + deprecated("list(Category.articles(...))") return sorted(list(set(self.articles(recurse)))) def supercategories(self): """DEPRECATED: equivalent to self.categories()""" - logger.debug(u"Category.supercategories() method is deprecated.") + deprecated("Category.categories()") return self.categories() def supercategoriesList(self): """DEPRECATED: equivalent to list(self.categories(...))""" - logger.debug(u"Category.articlesList() method is deprecated.") + deprecated("list(Category.categories(...))") return sorted(list(set(self.categories()))) Modified: branches/rewrite/pywikibot/site.py =================================================================== --- branches/rewrite/pywikibot/site.py 2009-02-22 11:32:12 UTC (rev 6409) +++ branches/rewrite/pywikibot/site.py 2009-02-22 12:31:24 UTC (rev 6410) @@ -13,6 +13,7 @@ import pywikibot from pywikibot import deprecate_arg from pywikibot import config +from pywikibot import deprecated from pywikibot.throttle import Throttle from pywikibot.data import api from pywikibot.exceptions import * @@ -313,7 +314,7 @@ Use optional Site argument 'othersite' to generate an interwiki link. """ - logger.debug("Site.linkto() method is deprecated; use pywikibot.Link") + deprecated("pywikibot.Link") return pywikibot.Link(title, self).astext(othersite) def isInterwikiLink(self, s): @@ -408,10 +409,12 @@ def fam(self): """Return Family object for this Site.""" + deprecated("family attribute") return self.family def urlEncode(self, query): """DEPRECATED""" + deprecated("urllib.urlencode()") return urllib.urlencode(query) def getUrl(self, path, retry=True, sysop=False, data=None, @@ -422,6 +425,7 @@ are ignored. """ + deprecated("pywikibot.comms.data.request") if data: if not isinstance(data, basestring): data = urllib.urlencode(data) @@ -432,11 +436,13 @@ def postForm(self, address, predata, sysop=False, cookies=None): """DEPRECATED""" + deprecated() return self.getUrl(address, data=predata) def postData(self, address, data, contentType=None, sysop=False, compress=True, cookies=None): """DEPRECATED""" + deprecated() return self.getUrl(address, data=data) # unsupported methods from version 1 @@ -635,7 +641,7 @@ DEPRECATED (use .user() method instead) """ - logger.debug("Site.loggedInAs() method is deprecated.") + deprecated("Site.user()") return self.logged_in(sysop) and self.user() def login(self, sysop=False): @@ -729,7 +735,7 @@ def isAllowed(self, right, sysop=False): """Deprecated; retained for backwards-compatibility""" - logger.debug("Site.isAllowed() method is deprecated; use has_right()") + deprecated("Site.has_right()") return self.has_right(right, sysop) def has_group(self, group, sysop=False): @@ -1459,7 +1465,7 @@ Use allpages() with the prefix= parameter instead of this method. """ - logger.debug("Site.prefixindex() is deprecated; use allpages instead.") + deprecated("Site.allpages()") return self.allpages(prefix=prefix, namespace=namespace, includeredirects=includeredirects) @@ -1533,8 +1539,7 @@ def categories(self, number=10, repeat=False): """Deprecated; retained for backwards-compatibility""" - logger.debug( - "Site.categories() method is deprecated; use .allcategories()") + deprecated("Site.allcategories()") if repeat: limit = None else:

15 years, 2 months

← Newer
1
...
4
5
6
7
8
9
10
...
23
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

Pywikipedia-l February 2009